For beta version 2024-08-16 - import token beta #5267
Draft
+1,394
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inity/nns-dapp into mstr/imported-tokens-services
# Conflicts: # frontend/src/lib/i18n/en.json
commit 3fa7e3f Author: Max Strasinsky <[email protected]> Date: Thu Aug 15 14:01:08 2024 +0200 Changelog commit 592830e Author: Max Strasinsky <[email protected]> Date: Thu Aug 15 13:36:49 2024 +0200 Attempt to fix safari table glitch
mstrasinskis
changed the title
commit 246e65c Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 16:09:35 2024 +0200 Revert "style: Import button redesign" This reverts commit fb9907d. commit 9ddec40 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 16:08:53 2024 +0200 Fix loading imported tokens before the NNS account was created. commit 87042ae Merge: 9efce2c 845afe3 Author: Max Strasinsky <[email protected]> Date: Tue Aug 20 15:18:46 2024 +0200 Merge branch 'main' into mstr/imported-tokens-form commit 845afe3 Author: David de Kloet <[email protected]> Date: Tue Aug 20 12:14:36 2024 +0200 Explicitly upload checklist file in release-sop (#5334) # Motivation In the NNS dapp release SOP checklist there is a step: > gh release upload "proposal-$PROPOSAL_ID" scripts/nns-dapp/Release-*.json To upload the release-sop JSON file to the release assets. Using `*` makes it easy to copy/paste the command but in the `release-sop` script we can be more precise and avoid matching other JSON. When running the test there is a different JSON file but if an actual release is ongoing the test would see that file too. # Changes 1. Explicitly upload the checklist file for the current release instead of using wild cards. 2. Drive-by: Fix typos of "relese" to "release". # Tests 1. The existing `release-sop.test` still passes. 2. I tried running the test after doing `touch scripts/nns-dapp/Release-2024-02-29.json` and it failed without the change and passed with the change. # Todos - [ ] Add entry to changelog (if necessary). not necessary commit 1d9487b Author: David de Kloet <[email protected]> Date: Tue Aug 20 11:20:26 2024 +0200 NNS1-3250: Dispatch event for click on non-link table row (#5333) # Motivation In the staking projects table, when you click on a project for which you don't have any neurons, instead of navigating to the (empty) neurons table for that project, we want to open the staking modal. This means that those rows should not be links (which would cause navigation) but should clicks should instead dispatch an event which can be used to open the modal. This PR only implements dispatching the event for non-link rows and does not yet do anything with it. # Changes When a non-link row is clicked in the `ResponsiveTable`, dispatch an `nnsAction` event with the `rowData` for that row as event payload. # Tests 1. Unit test added. 2. Tested manually in another branch which already has the staking modal implemented: https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/staking/ # Todos - [ ] Add entry to changelog (if necessary). not necessary commit f3cabd2 Author: Max Strasinsky <[email protected]> Date: Mon Aug 19 15:06:29 2024 +0200 Update changelog after release (#5328) # Motivation A release has been deployed to production. # Changes - Changelog - split out the changes included in the release. - A single entry (Fixed incorrect interpretation of ICRC fees), was added manually because we forgot to update the changelog in the fix PR. - Increment the patch version of the nns-dapp. commit 0540daf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 08:24:32 2024 +0000 Bump ic-cdk from 0.15.0 to 0.15.1 (#5324) Bumps [ic-cdk](https://github.com/dfinity/cdk-rs) from 0.15.0 to 0.15.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/dfinity/cdk-rs/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4cc2cee Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 10:23:48 2024 +0200 Bump serde_json from 1.0.124 to 1.0.125 (#5325) Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.124 to 1.0.125. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>1.0.125</h2> <ul> <li>Speed up \uXXXX parsing and improve handling of unpaired surrogates when deserializing to bytes (<a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a>, <a href="https://redirect.github.com/serde-rs/json/issues/1175">#1175</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/6130f9b358dea483f10e671343f0098fbe55611b"><code>6130f9b</code></a> Release 1.0.125</li> <li><a href="https://github.com/serde-rs/json/commit/cc7a1608c9bb7736c884926e016421af41a1ebe7"><code>cc7a160</code></a> Touch up PR 1175</li> <li><a href="https://github.com/serde-rs/json/commit/0f942e5b5235a3b586e20e4c00bfe5b1a56f16d8"><code>0f942e5</code></a> Merge pull request 1175 from iex-rs/faster-backslash-u</li> <li><a href="https://github.com/serde-rs/json/commit/d8921cd29b5eef6263c20cf87eab25d961237f94"><code>d8921cd</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a> from iex-rs/faster-hex</li> <li><a href="https://github.com/serde-rs/json/commit/b4bc6436acdf874729a7b425b3c2e48f8b16b398"><code>b4bc643</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1176">#1176</a> from dtolnay/miriname</li> <li><a href="https://github.com/serde-rs/json/commit/94a2aad7b79543454da3ecdb2e6170b98773ccc2"><code>94a2aad</code></a> Improve job names for miri jobs</li> <li><a href="https://github.com/serde-rs/json/commit/8073fc16b89f508f2443b95d925ce59dca745d43"><code>8073fc1</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1174">#1174</a> from iex-rs/miri-on-ci</li> <li><a href="https://github.com/serde-rs/json/commit/96ae60445df67f6903b53b2fcfe1d60f3bd8f778"><code>96ae604</code></a> Correct WTF-8 parsing</li> <li><a href="https://github.com/serde-rs/json/commit/236cc8247d32a5cb337850d75f68265fdb4bc14e"><code>236cc82</code></a> Simplify unicode escape handling</li> <li><a href="https://github.com/serde-rs/json/commit/2f28d106e68e214cfa19043e65b1bd178b3c2ced"><code>2f28d10</code></a> Use the same UTF-8/WTF-8 impl for surrogates</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.124...1.0.125">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6a67787 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 10:23:16 2024 +0200 Bump serde from 1.0.206 to 1.0.208 (#5326) Bumps [serde](https://github.com/serde-rs/serde) from 1.0.206 to 1.0.208. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.208</h2> <ul> <li>Support serializing and deserializing unit structs in a <code>flatten</code> field (<a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a>, thanks <a href="https://github.com/jonhoo"><code>@jonhoo</code></a>)</li> </ul> <h2>v1.0.207</h2> <ul> <li>Improve interactions between <code>flatten</code> attribute and <code>skip_serializing</code>/<code>skip_deserializing</code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/026e91a68cdb00ed89bae5f566852ecbd7525315"><code>026e91a</code></a> Release 1.0.208</li> <li><a href="https://github.com/serde-rs/serde/commit/bfbedac91940b7cbe268bf686b93812b3020129c"><code>bfbedac</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a> from jonhoo/flatten-unit-struct</li> <li><a href="https://github.com/serde-rs/serde/commit/4036ff88edc2ee85f288e8c9bc6d9a0f393cf96e"><code>4036ff8</code></a> Support (de-)serializing flattened unit struct</li> <li><a href="https://github.com/serde-rs/serde/commit/1b4da41f970555e111f471633205bbcb4dadbc63"><code>1b4da41</code></a> Release 1.0.207</li> <li><a href="https://github.com/serde-rs/serde/commit/f61d452814d6c7bf32d139e747d18c21592d702a"><code>f61d452</code></a> Touch up PR 2795</li> <li><a href="https://github.com/serde-rs/serde/commit/f9866097a084e2e549e40c4d47f7ee171e0a6aaf"><code>f986609</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a> from Mingun/has-flatten-rework</li> <li><a href="https://github.com/serde-rs/serde/commit/77a6a9d4e193c82439aa0c35dfdbbb34fafdf38e"><code>77a6a9d</code></a> Take into account only not skipped flatten fields when choose serialization form</li> <li><a href="https://github.com/serde-rs/serde/commit/547d843ccaa1349b074991f5ceeda722cf245824"><code>547d843</code></a> Remove dead code - serialize_struct_as_map always called when cattrs.has_flat...</li> <li><a href="https://github.com/serde-rs/serde/commit/005cb84593e73cb3ba263232cc5f09b77859ec5b"><code>005cb84</code></a> Fail with an understandable message is number of fields for serialization is ...</li> <li><a href="https://github.com/serde-rs/serde/commit/fd5b5e9aa561e29d9312ecef2019ec670b4bc334"><code>fd5b5e9</code></a> Correctly calculate <code>has_flatten</code> attribute in all cases for deserialization</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.206...v1.0.208">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2426cae Author: jasonz-dfinity <[email protected]> Date: Fri Aug 16 18:24:32 2024 +0200 Remove integration test setup code and script (#5322) # Motivation The integration tests using PocketIC was added for stable structure migration. The tests themselves are already removed in #4814, while the test setup and the github workflow is still there. # Changes * Remove the test setup code * Remove the github workflow * Remove test script * Remove related documentation # Tests N/A # Todos - [x] Add entry to changelog (if necessary). commit 9efce2c Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 10:05:43 2024 +0200 Remove redundant lables commit f9011dd Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:53:28 2024 +0200 Fix type warnings commit 7e1cf6b Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:42:44 2024 +0200 Fix type warnings commit 10cf9ce Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:40:20 2024 +0200 Formatting commit 6f5d3b8 Author: sa-github-api <[email protected]> Date: Fri Aug 16 13:09:32 2024 +0200 bot: Update SNS Aggregator Response (#5318) # Motivation We would like to keep the ProdLaunchpad.spec up to date with mainnet data. # Changes * Update the files used for the fetch mock in ProdLaunchpad.spec. # Tests Only test changes. Co-authored-by: gix-bot <[email protected]> commit 1072976 Author: sa-github-api <[email protected]> Date: Fri Aug 16 11:17:40 2024 +0200 bot: Update snsdemo to release-2024-08-14 (#5323) # Motivation We would like to keep the testing environment, provided by snsdemo, up to date. # Changes * Updated `snsdemo` version in `dfx.json`. * Ensured that the `dfx` version in `dfx.json` matches `snsdemo`. # Tests CI should pass. Co-authored-by: gix-bot <[email protected]>
commit 3923923 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 17:27:35 2024 +0200 test: should not show import token button when they are not loaded commit 037c598 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 17:19:43 2024 +0200 Adjust ImportTokenCanisterId.spec to new sub components commit 246e65c Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 16:09:35 2024 +0200 Revert "style: Import button redesign" This reverts commit fb9907d. commit 9ddec40 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 16:08:53 2024 +0200 Fix loading imported tokens before the NNS account was created. commit 87042ae Merge: 9efce2c 845afe3 Author: Max Strasinsky <[email protected]> Date: Tue Aug 20 15:18:46 2024 +0200 Merge branch 'main' into mstr/imported-tokens-form commit 845afe3 Author: David de Kloet <[email protected]> Date: Tue Aug 20 12:14:36 2024 +0200 Explicitly upload checklist file in release-sop (#5334) # Motivation In the NNS dapp release SOP checklist there is a step: > gh release upload "proposal-$PROPOSAL_ID" scripts/nns-dapp/Release-*.json To upload the release-sop JSON file to the release assets. Using `*` makes it easy to copy/paste the command but in the `release-sop` script we can be more precise and avoid matching other JSON. When running the test there is a different JSON file but if an actual release is ongoing the test would see that file too. # Changes 1. Explicitly upload the checklist file for the current release instead of using wild cards. 2. Drive-by: Fix typos of "relese" to "release". # Tests 1. The existing `release-sop.test` still passes. 2. I tried running the test after doing `touch scripts/nns-dapp/Release-2024-02-29.json` and it failed without the change and passed with the change. # Todos - [ ] Add entry to changelog (if necessary). not necessary commit 1d9487b Author: David de Kloet <[email protected]> Date: Tue Aug 20 11:20:26 2024 +0200 NNS1-3250: Dispatch event for click on non-link table row (#5333) # Motivation In the staking projects table, when you click on a project for which you don't have any neurons, instead of navigating to the (empty) neurons table for that project, we want to open the staking modal. This means that those rows should not be links (which would cause navigation) but should clicks should instead dispatch an event which can be used to open the modal. This PR only implements dispatching the event for non-link rows and does not yet do anything with it. # Changes When a non-link row is clicked in the `ResponsiveTable`, dispatch an `nnsAction` event with the `rowData` for that row as event payload. # Tests 1. Unit test added. 2. Tested manually in another branch which already has the staking modal implemented: https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/staking/ # Todos - [ ] Add entry to changelog (if necessary). not necessary commit f3cabd2 Author: Max Strasinsky <[email protected]> Date: Mon Aug 19 15:06:29 2024 +0200 Update changelog after release (#5328) # Motivation A release has been deployed to production. # Changes - Changelog - split out the changes included in the release. - A single entry (Fixed incorrect interpretation of ICRC fees), was added manually because we forgot to update the changelog in the fix PR. - Increment the patch version of the nns-dapp. commit 0540daf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 08:24:32 2024 +0000 Bump ic-cdk from 0.15.0 to 0.15.1 (#5324) Bumps [ic-cdk](https://github.com/dfinity/cdk-rs) from 0.15.0 to 0.15.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/dfinity/cdk-rs/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4cc2cee Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 10:23:48 2024 +0200 Bump serde_json from 1.0.124 to 1.0.125 (#5325) Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.124 to 1.0.125. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>1.0.125</h2> <ul> <li>Speed up \uXXXX parsing and improve handling of unpaired surrogates when deserializing to bytes (<a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a>, <a href="https://redirect.github.com/serde-rs/json/issues/1175">#1175</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/6130f9b358dea483f10e671343f0098fbe55611b"><code>6130f9b</code></a> Release 1.0.125</li> <li><a href="https://github.com/serde-rs/json/commit/cc7a1608c9bb7736c884926e016421af41a1ebe7"><code>cc7a160</code></a> Touch up PR 1175</li> <li><a href="https://github.com/serde-rs/json/commit/0f942e5b5235a3b586e20e4c00bfe5b1a56f16d8"><code>0f942e5</code></a> Merge pull request 1175 from iex-rs/faster-backslash-u</li> <li><a href="https://github.com/serde-rs/json/commit/d8921cd29b5eef6263c20cf87eab25d961237f94"><code>d8921cd</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a> from iex-rs/faster-hex</li> <li><a href="https://github.com/serde-rs/json/commit/b4bc6436acdf874729a7b425b3c2e48f8b16b398"><code>b4bc643</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1176">#1176</a> from dtolnay/miriname</li> <li><a href="https://github.com/serde-rs/json/commit/94a2aad7b79543454da3ecdb2e6170b98773ccc2"><code>94a2aad</code></a> Improve job names for miri jobs</li> <li><a href="https://github.com/serde-rs/json/commit/8073fc16b89f508f2443b95d925ce59dca745d43"><code>8073fc1</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1174">#1174</a> from iex-rs/miri-on-ci</li> <li><a href="https://github.com/serde-rs/json/commit/96ae60445df67f6903b53b2fcfe1d60f3bd8f778"><code>96ae604</code></a> Correct WTF-8 parsing</li> <li><a href="https://github.com/serde-rs/json/commit/236cc8247d32a5cb337850d75f68265fdb4bc14e"><code>236cc82</code></a> Simplify unicode escape handling</li> <li><a href="https://github.com/serde-rs/json/commit/2f28d106e68e214cfa19043e65b1bd178b3c2ced"><code>2f28d10</code></a> Use the same UTF-8/WTF-8 impl for surrogates</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.124...1.0.125">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6a67787 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 10:23:16 2024 +0200 Bump serde from 1.0.206 to 1.0.208 (#5326) Bumps [serde](https://github.com/serde-rs/serde) from 1.0.206 to 1.0.208. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.208</h2> <ul> <li>Support serializing and deserializing unit structs in a <code>flatten</code> field (<a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a>, thanks <a href="https://github.com/jonhoo"><code>@jonhoo</code></a>)</li> </ul> <h2>v1.0.207</h2> <ul> <li>Improve interactions between <code>flatten</code> attribute and <code>skip_serializing</code>/<code>skip_deserializing</code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/026e91a68cdb00ed89bae5f566852ecbd7525315"><code>026e91a</code></a> Release 1.0.208</li> <li><a href="https://github.com/serde-rs/serde/commit/bfbedac91940b7cbe268bf686b93812b3020129c"><code>bfbedac</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a> from jonhoo/flatten-unit-struct</li> <li><a href="https://github.com/serde-rs/serde/commit/4036ff88edc2ee85f288e8c9bc6d9a0f393cf96e"><code>4036ff8</code></a> Support (de-)serializing flattened unit struct</li> <li><a href="https://github.com/serde-rs/serde/commit/1b4da41f970555e111f471633205bbcb4dadbc63"><code>1b4da41</code></a> Release 1.0.207</li> <li><a href="https://github.com/serde-rs/serde/commit/f61d452814d6c7bf32d139e747d18c21592d702a"><code>f61d452</code></a> Touch up PR 2795</li> <li><a href="https://github.com/serde-rs/serde/commit/f9866097a084e2e549e40c4d47f7ee171e0a6aaf"><code>f986609</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a> from Mingun/has-flatten-rework</li> <li><a href="https://github.com/serde-rs/serde/commit/77a6a9d4e193c82439aa0c35dfdbbb34fafdf38e"><code>77a6a9d</code></a> Take into account only not skipped flatten fields when choose serialization form</li> <li><a href="https://github.com/serde-rs/serde/commit/547d843ccaa1349b074991f5ceeda722cf245824"><code>547d843</code></a> Remove dead code - serialize_struct_as_map always called when cattrs.has_flat...</li> <li><a href="https://github.com/serde-rs/serde/commit/005cb84593e73cb3ba263232cc5f09b77859ec5b"><code>005cb84</code></a> Fail with an understandable message is number of fields for serialization is ...</li> <li><a href="https://github.com/serde-rs/serde/commit/fd5b5e9aa561e29d9312ecef2019ec670b4bc334"><code>fd5b5e9</code></a> Correctly calculate <code>has_flatten</code> attribute in all cases for deserialization</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.206...v1.0.208">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2426cae Author: jasonz-dfinity <[email protected]> Date: Fri Aug 16 18:24:32 2024 +0200 Remove integration test setup code and script (#5322) # Motivation The integration tests using PocketIC was added for stable structure migration. The tests themselves are already removed in #4814, while the test setup and the github workflow is still there. # Changes * Remove the test setup code * Remove the github workflow * Remove test script * Remove related documentation # Tests N/A # Todos - [x] Add entry to changelog (if necessary). commit 9efce2c Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 10:05:43 2024 +0200 Remove redundant lables commit f9011dd Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:53:28 2024 +0200 Fix type warnings commit 7e1cf6b Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:42:44 2024 +0200 Fix type warnings commit 10cf9ce Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:40:20 2024 +0200 Formatting commit 6f5d3b8 Author: sa-github-api <[email protected]> Date: Fri Aug 16 13:09:32 2024 +0200 bot: Update SNS Aggregator Response (#5318) # Motivation We would like to keep the ProdLaunchpad.spec up to date with mainnet data. # Changes * Update the files used for the fetch mock in ProdLaunchpad.spec. # Tests Only test changes. Co-authored-by: gix-bot <[email protected]> commit 1072976 Author: sa-github-api <[email protected]> Date: Fri Aug 16 11:17:40 2024 +0200 bot: Update snsdemo to release-2024-08-14 (#5323) # Motivation We would like to keep the testing environment, provided by snsdemo, up to date. # Changes * Updated `snsdemo` version in `dfx.json`. * Ensured that the `dfx` version in `dfx.json` matches `snsdemo`. # Tests CI should pass. Co-authored-by: gix-bot <[email protected]>
commit 87f9cd1 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 17:36:46 2024 +0200 Fix outdated specs commit 3923923 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 17:27:35 2024 +0200 test: should not show import token button when they are not loaded commit 037c598 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 17:19:43 2024 +0200 Adjust ImportTokenCanisterId.spec to new sub components commit 246e65c Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 16:09:35 2024 +0200 Revert "style: Import button redesign" This reverts commit fb9907d. commit 9ddec40 Author: Max Strasinsky <[email protected]> Date: Wed Aug 21 16:08:53 2024 +0200 Fix loading imported tokens before the NNS account was created. commit 87042ae Merge: 9efce2c 845afe3 Author: Max Strasinsky <[email protected]> Date: Tue Aug 20 15:18:46 2024 +0200 Merge branch 'main' into mstr/imported-tokens-form commit 845afe3 Author: David de Kloet <[email protected]> Date: Tue Aug 20 12:14:36 2024 +0200 Explicitly upload checklist file in release-sop (#5334) # Motivation In the NNS dapp release SOP checklist there is a step: > gh release upload "proposal-$PROPOSAL_ID" scripts/nns-dapp/Release-*.json To upload the release-sop JSON file to the release assets. Using `*` makes it easy to copy/paste the command but in the `release-sop` script we can be more precise and avoid matching other JSON. When running the test there is a different JSON file but if an actual release is ongoing the test would see that file too. # Changes 1. Explicitly upload the checklist file for the current release instead of using wild cards. 2. Drive-by: Fix typos of "relese" to "release". # Tests 1. The existing `release-sop.test` still passes. 2. I tried running the test after doing `touch scripts/nns-dapp/Release-2024-02-29.json` and it failed without the change and passed with the change. # Todos - [ ] Add entry to changelog (if necessary). not necessary commit 1d9487b Author: David de Kloet <[email protected]> Date: Tue Aug 20 11:20:26 2024 +0200 NNS1-3250: Dispatch event for click on non-link table row (#5333) # Motivation In the staking projects table, when you click on a project for which you don't have any neurons, instead of navigating to the (empty) neurons table for that project, we want to open the staking modal. This means that those rows should not be links (which would cause navigation) but should clicks should instead dispatch an event which can be used to open the modal. This PR only implements dispatching the event for non-link rows and does not yet do anything with it. # Changes When a non-link row is clicked in the `ResponsiveTable`, dispatch an `nnsAction` event with the `rowData` for that row as event payload. # Tests 1. Unit test added. 2. Tested manually in another branch which already has the staking modal implemented: https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/staking/ # Todos - [ ] Add entry to changelog (if necessary). not necessary commit f3cabd2 Author: Max Strasinsky <[email protected]> Date: Mon Aug 19 15:06:29 2024 +0200 Update changelog after release (#5328) # Motivation A release has been deployed to production. # Changes - Changelog - split out the changes included in the release. - A single entry (Fixed incorrect interpretation of ICRC fees), was added manually because we forgot to update the changelog in the fix PR. - Increment the patch version of the nns-dapp. commit 0540daf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 08:24:32 2024 +0000 Bump ic-cdk from 0.15.0 to 0.15.1 (#5324) Bumps [ic-cdk](https://github.com/dfinity/cdk-rs) from 0.15.0 to 0.15.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/dfinity/cdk-rs/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4cc2cee Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 10:23:48 2024 +0200 Bump serde_json from 1.0.124 to 1.0.125 (#5325) Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.124 to 1.0.125. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>1.0.125</h2> <ul> <li>Speed up \uXXXX parsing and improve handling of unpaired surrogates when deserializing to bytes (<a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a>, <a href="https://redirect.github.com/serde-rs/json/issues/1175">#1175</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/6130f9b358dea483f10e671343f0098fbe55611b"><code>6130f9b</code></a> Release 1.0.125</li> <li><a href="https://github.com/serde-rs/json/commit/cc7a1608c9bb7736c884926e016421af41a1ebe7"><code>cc7a160</code></a> Touch up PR 1175</li> <li><a href="https://github.com/serde-rs/json/commit/0f942e5b5235a3b586e20e4c00bfe5b1a56f16d8"><code>0f942e5</code></a> Merge pull request 1175 from iex-rs/faster-backslash-u</li> <li><a href="https://github.com/serde-rs/json/commit/d8921cd29b5eef6263c20cf87eab25d961237f94"><code>d8921cd</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a> from iex-rs/faster-hex</li> <li><a href="https://github.com/serde-rs/json/commit/b4bc6436acdf874729a7b425b3c2e48f8b16b398"><code>b4bc643</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1176">#1176</a> from dtolnay/miriname</li> <li><a href="https://github.com/serde-rs/json/commit/94a2aad7b79543454da3ecdb2e6170b98773ccc2"><code>94a2aad</code></a> Improve job names for miri jobs</li> <li><a href="https://github.com/serde-rs/json/commit/8073fc16b89f508f2443b95d925ce59dca745d43"><code>8073fc1</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1174">#1174</a> from iex-rs/miri-on-ci</li> <li><a href="https://github.com/serde-rs/json/commit/96ae60445df67f6903b53b2fcfe1d60f3bd8f778"><code>96ae604</code></a> Correct WTF-8 parsing</li> <li><a href="https://github.com/serde-rs/json/commit/236cc8247d32a5cb337850d75f68265fdb4bc14e"><code>236cc82</code></a> Simplify unicode escape handling</li> <li><a href="https://github.com/serde-rs/json/commit/2f28d106e68e214cfa19043e65b1bd178b3c2ced"><code>2f28d10</code></a> Use the same UTF-8/WTF-8 impl for surrogates</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.124...1.0.125">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6a67787 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Aug 19 10:23:16 2024 +0200 Bump serde from 1.0.206 to 1.0.208 (#5326) Bumps [serde](https://github.com/serde-rs/serde) from 1.0.206 to 1.0.208. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.208</h2> <ul> <li>Support serializing and deserializing unit structs in a <code>flatten</code> field (<a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a>, thanks <a href="https://github.com/jonhoo"><code>@jonhoo</code></a>)</li> </ul> <h2>v1.0.207</h2> <ul> <li>Improve interactions between <code>flatten</code> attribute and <code>skip_serializing</code>/<code>skip_deserializing</code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/026e91a68cdb00ed89bae5f566852ecbd7525315"><code>026e91a</code></a> Release 1.0.208</li> <li><a href="https://github.com/serde-rs/serde/commit/bfbedac91940b7cbe268bf686b93812b3020129c"><code>bfbedac</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a> from jonhoo/flatten-unit-struct</li> <li><a href="https://github.com/serde-rs/serde/commit/4036ff88edc2ee85f288e8c9bc6d9a0f393cf96e"><code>4036ff8</code></a> Support (de-)serializing flattened unit struct</li> <li><a href="https://github.com/serde-rs/serde/commit/1b4da41f970555e111f471633205bbcb4dadbc63"><code>1b4da41</code></a> Release 1.0.207</li> <li><a href="https://github.com/serde-rs/serde/commit/f61d452814d6c7bf32d139e747d18c21592d702a"><code>f61d452</code></a> Touch up PR 2795</li> <li><a href="https://github.com/serde-rs/serde/commit/f9866097a084e2e549e40c4d47f7ee171e0a6aaf"><code>f986609</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a> from Mingun/has-flatten-rework</li> <li><a href="https://github.com/serde-rs/serde/commit/77a6a9d4e193c82439aa0c35dfdbbb34fafdf38e"><code>77a6a9d</code></a> Take into account only not skipped flatten fields when choose serialization form</li> <li><a href="https://github.com/serde-rs/serde/commit/547d843ccaa1349b074991f5ceeda722cf245824"><code>547d843</code></a> Remove dead code - serialize_struct_as_map always called when cattrs.has_flat...</li> <li><a href="https://github.com/serde-rs/serde/commit/005cb84593e73cb3ba263232cc5f09b77859ec5b"><code>005cb84</code></a> Fail with an understandable message is number of fields for serialization is ...</li> <li><a href="https://github.com/serde-rs/serde/commit/fd5b5e9aa561e29d9312ecef2019ec670b4bc334"><code>fd5b5e9</code></a> Correctly calculate <code>has_flatten</code> attribute in all cases for deserialization</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.206...v1.0.208">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2426cae Author: jasonz-dfinity <[email protected]> Date: Fri Aug 16 18:24:32 2024 +0200 Remove integration test setup code and script (#5322) # Motivation The integration tests using PocketIC was added for stable structure migration. The tests themselves are already removed in #4814, while the test setup and the github workflow is still there. # Changes * Remove the test setup code * Remove the github workflow * Remove test script * Remove related documentation # Tests N/A # Todos - [x] Add entry to changelog (if necessary). commit 9efce2c Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 10:05:43 2024 +0200 Remove redundant lables commit f9011dd Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:53:28 2024 +0200 Fix type warnings commit 7e1cf6b Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:42:44 2024 +0200 Fix type warnings commit 10cf9ce Author: Max Strasinsky <[email protected]> Date: Fri Aug 16 09:40:20 2024 +0200 Formatting commit 6f5d3b8 Author: sa-github-api <[email protected]> Date: Fri Aug 16 13:09:32 2024 +0200 bot: Update SNS Aggregator Response (#5318) # Motivation We would like to keep the ProdLaunchpad.spec up to date with mainnet data. # Changes * Update the files used for the fetch mock in ProdLaunchpad.spec. # Tests Only test changes. Co-authored-by: gix-bot <[email protected]> commit 1072976 Author: sa-github-api <[email protected]> Date: Fri Aug 16 11:17:40 2024 +0200 bot: Update snsdemo to release-2024-08-14 (#5323) # Motivation We would like to keep the testing environment, provided by snsdemo, up to date. # Changes * Updated `snsdemo` version in `dfx.json`. * Ensured that the `dfx` version in `dfx.json` matches `snsdemo`. # Tests CI should pass. Co-authored-by: gix-bot <[email protected]>
…y/nns-dapp into mstr/import-token-beta-2024-08-02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE