Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(BOUN-1252): remove vector-lib dependency #47

Merged
merged 2 commits into from
Oct 11, 2024
Merged

chore(BOUN-1252): remove vector-lib dependency #47

merged 2 commits into from
Oct 11, 2024

Conversation

blind-oracle
Copy link
Collaborator

@blind-oracle blind-oracle commented Oct 11, 2024 •
edited
Loading

Use a minimal implementation from ic-bn-lib (https://github.com/dfinity/ic-bn-lib/blob/main/src/vector/mod.rs).

Also update some dependencies.

@blind-oracle blind-oracle requested a review from a team as a code owner October 11, 2024 18:38
r-birkner
r-birkner approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@r-birkner r-birkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blind-oracle blind-oracle merged commit 0712978 into main Oct 11, 2024
3 checks passed
@blind-oracle blind-oracle deleted the igornovg/vector-untie branch October 11, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-birkner r-birkner r-birkner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blind-oracle @r-birkner