Tag color variables #529
Merged
Tag color variables #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
reviewed
Nov 12, 2024
…nents into theme-level-tag-colors
dskloetd
reviewed
Nov 12, 2024
1 task
dskloetd
approved these changes
Nov 13, 2024
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Nov 13, 2024
# Motivation Update the proposal tag colors to match the design. Note: 1. The colors for the “Open” and “Adopted” statuses have been switched because blue is the action color. 2. Use the default tag colors for the “Unknown” status instead of a disable colors to ensure tag colors are used consistently. # Changes - Switch to proposal color css vars ([gix-compoenent pr](dfinity/gix-components#529)). # Tests - Tested manually. ## Light from -> to  <img width="880" alt="image" src="https://github.com/user-attachments/assets/0ccd98d8-ab3a-4842-91f5-41b6d02f13c2"> ## Dark from -> to  <img width="876" alt="image" src="https://github.com/user-attachments/assets/7e446175-1074-4c71-ad9a-c97e36afa5f0"> # Todos - [x] Add entry to changelog (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, primitive colors are used in the proposal status tags. To make it more organized, we are creating separate variables for each proposal status (except for the status Unknown, as it’s not a real status and uses a
disableddefault style).Changes
Screenshots
No visual changes yet.