Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner #511

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add banner #511

wants to merge 1 commit into from

Conversation

coskucinkilic
Copy link
Contributor

@coskucinkilic coskucinkilic commented Oct 18, 2024 •
edited
Loading

Motivation

Gix-components already have PageBanner component but it is build to be used in the landing pages. In NnsDapp we were about to create a second banner, it would be great to have a reusable Banner component to display temporary information with action button if necessary.

Changes

  1. Add Banner component
  2. Update docs
  3. Add tests for Banner

These tests cover the main functionality of the Banner component:

  • Rendering when visible is true
  • Not rendering when visible is false
  • Rendering slotted content
  • Closing the banner when the close button is clicked
  • Applying a custom test ID

Screenshots

Screenshot 2024-10-18 at 14 29 45

@coskucinkilic coskucinkilic marked this pull request as ready for review October 18, 2024 12:42
@coskucinkilic coskucinkilic requested review from a team as code owners October 18, 2024 12:42
@coskucinkilic coskucinkilic marked this pull request as draft October 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coskucinkilic