Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: card spacing and alignment #267

Merged
merged 5 commits into from
Aug 2, 2023
Merged

fix: card spacing and alignment #267

merged 5 commits into from
Aug 2, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

Card spacing and alignment is not 100% precise following introduction of the card links.

Note

This PR also partially revert #266 to previous values.

Changes

  • play with margins

Screenshots

Issues

issue-1 issue-2

After

Capture d’écran 2023-08-02 à 11 40 45 Capture d’écran 2023-08-02 à 11 40 37 Capture d’écran 2023-08-02 à 11 40 12 Capture d’écran 2023-08-02 à 11 40 09 Capture d’écran 2023-08-02 à 11 40 04

@peterpeterparker peterpeterparker added the bug Something isn't working label Aug 2, 2023
@peterpeterparker peterpeterparker mentioned this pull request Aug 2, 2023
Merged
6 tasks
mstrasinskis
mstrasinskis approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 0f90dcf into main Aug 2, 2023
@peterpeterparker peterpeterparker deleted the fix/card-spacing branch August 2, 2023 10:53
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Aug 2, 2023
@peterpeterparker
Improve ux by using hyperlinks for the cards (#3005)
2334b10 
# Motivation

Accounts, neurons, proposals, launchpad and canisters cards are button
which is a bit annoying as it makes complicated for the users to work
with multiple tabs. By modifying these cards to become real hyperlinks,
we will allow the user to open more easily information in separate tabs.

# PRs

- [x] dfinity/gix-components#262
- [x] dfinity/gix-components#267
- [x] dfinity/gix-components#266
- [x] dfinity/gix-components#265
- [x] dfinity/gix-components#264
- [x] dfinity/gix-components#263

# Changes

- provide new property `href` instead of using `on:click` to navigate
through the cards from pages to details page
- review `role` of the cards

# Screenshots


![demo](https://github.com/dfinity/nns-dapp/assets/16886711/11def01f-1f25-4f54-9548-b86fd56eb73a)
@dskloetd dskloetd mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @mstrasinskis