-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip range check when the certificate comes from the management canister #945
Conversation
size-limit report 📦
|
I think this is safe to add. We were overriding this check with a custom transformation for our |
@dfx-json did you try this with any live code? Do we know that |
Tested using @dfinity/ic-management - I can still reproduce the error with these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go, and I'm happy to have this new unit testing pattern. It's something we can probably polish and automate down the line, and will be improved with nicer tooling for passing fixed nonces
Resolves SDKTG-403 and a regression in the NNS dapp in versions of agent > 2.0.0