Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build paths on use-auth-client #922

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

pocesar
Copy link
Contributor

@pocesar pocesar commented Sep 8, 2024

Description

It's impossible to use @dfinity/use-auth-client right now because it points to a non-existing path, the package.json points to lib/(esm|cjs)/index.js

image

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sa-github-api
Copy link

Dear @pocesar,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@pocesar pocesar closed this Sep 8, 2024
@pocesar pocesar reopened this Sep 8, 2024
@krpeacock krpeacock enabled auto-merge (squash) September 11, 2024 21:00
@krpeacock krpeacock merged commit dae3812 into dfinity:main Sep 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants