feat: deprecate HttpAgent
constructor in favor of new create
#873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the pattern used by other interfaces in the library, this function switches to an async
create
method, that will be able to make thesyncTime
andfetchRootKey
calls before completing. This will also support future async setup calls if needed in the future.createSync
initializes the agent but skips any async steps, and is useful for testing or more sophisticated applicationsThe agent also has a
from
method, and will support either the v1 or v2 agent interfaces.The HttpAgent also switches to true es6 private class fields, and will formally reveal its config and its host as fields. This supports the from method, but the
_
-prefixed methods from older HttpAgents will be supported.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: