Dexie Cloud licensing support #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle error response from token endpoint * Update literal types: add 'client' license type as declared in dexie-cloud-common. * Don't show cancel button on alert messages * Auto-submit OTP when 8 characters are entered * Improve typings in defaultUI
+ allow token endpoint to send error instead of tokens
Don't connect websocket if license expired
* Don't throw if license is invalid. * Let expired/invalid user login and pull data (but not sync changes) * Allow change user without logging out first * db.cloud.logout() - logs out current user. * Request confirmation in case there are unsynced changes on logout
Instead, if there's already a scheduled retry, cancel that one when scheduling a new retry
…e transaction if db was vip.
* Warn if license is about to expire * Inform user is in offline mode if license is expired * Advertise to purchase a subscription if expired or about to expire * If expired, allow user to delete themself completely from the system.
* If only 50% of remaining is left, stall next sync until (reset / remaining) seconds * Bugfix - used registerSyncEvent() instead of triggerSync() - would only work in production with SW active. * Simplify performGuardedJob() using navigator.locks.
Javascript is a bit unsuprisingly forgiving when passing array of string instead of a string:
```js
const obj = {id: 1}
Object.hasOwnProperty(obj, "a"); // returns true as expected.
Object.hasOwnProperty(obj, ["a"]); // Also returns true (!)
obj["id"] // returns 1 as expected.
obj[["id"]] // also returns 1 (!)
```
This commit makes sure to check typeof keyPath before passing it to getOwn() (alias for `(x, a) => Object.prototype.getOwnProperty.call(x, a))``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for end-user evaluation licenses (see blog post about the new subscription model)