TLS enablement for check_odov2.sh and openshift_integration.sh
#531
Conversation
Signed-off-by: Michael Valdron <[email protected]>
|
/hold Waiting to discuss with team in the new year about alternatives before proceeding with this change. |
|
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -69,4 +69,4 @@ $(realpath odo) registry delete DefaultDevfileRegistry -f | |||
| $(realpath odo) registry add TestDevfileRegistry http://$REGISTRY_HOSTNAME | |||
|
|
|||
| # Run the devfile validation tests | |||
| ENV=openshift REGISTRY=remote tests/check_odov2.sh $(realpath odo) $YQ_PATH | |||
| ENV=openshift REGISTRY=remote ENABLE_TLS="false" tests/check_odov2.sh $(realpath odo) $YQ_PATH | |||
There was a problem hiding this comment.
I took a second look here. @michael-valdron out of curiosity, could we combine the two issues in the same PR (devfile/api#1664 is the other one). Meaning we could also migrate the check to odo3 here right? This way I guess the ci check will be unblocked
There was a problem hiding this comment.
@thepetk Yeah I can add the change to odov3 testing as well to unblock the testing entirely and resolve both. I'll work on and add it today.
Description of Changes
Summarize the changes you made as part of this pull request.
Adds TLS enablement feature for both the odo version 2 and openshift integration test scripts. This is to address the failing PR integration testing check due to the self signed cert not being accepted by
curlwhen testing stacks using HTTPS rather than HTTP.Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
fixes devfile/api#1663
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.