Make sure to run odo v3 tests for stacks that have no starter projects
#218
Conversation
|
@rm3l: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The tests pass on this branch, but without executing any actual v3 or v2 tests, because this PR did not change any files under the Meanwhile, I checked this PR in my own fork, by making changes to some stacks (with and without starter projects) and making sure that the odo v3 tests would run against those stacks. See rm3l#2: |
…s defined This is done via the `odo dev --no-commands` command (introduced in odo v3.12.0 [1]), to make sure that a Dev Session could actually be started properly. This is to cover cases for example where the container has a terminating command or ends up being restarted for some reason, or `odo` is unable to sync files. [1] https://odo.dev/docs/command-reference/dev#running-with-no-commands Signed-off-by: Armel Soro <[email protected]>
Signed-off-by: Armel Soro <[email protected]>
rm3l
force-pushed
the
1103-investigate-new-registry-stacks-not-executed-in-odo-v3-tests
branch
from
b2e8853 to
15c0a33
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rm3l
deleted the
1103-investigate-new-registry-stacks-not-executed-in-odo-v3-tests
branch
What does this PR do?:
/kind bug
This fixes the issue reported in devfile/api#1103, where the
odo v3tests would not run any tests on certain stacks.The issue has been narrowed down to stacks that have no starter projects in their Devfiles, like udi.
This PR makes sure to test such stacks, by leveraging the
odo dev --no-commandscommand, to check that the Dev Session just starts properly.Which issue(s) this PR fixes:
Fixes devfile/api#1103
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: