-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 #212
Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 #212
Conversation
fb1f16b
to
4d6b8fb
Compare
4d6b8fb
to
06b3292
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thepetk This one is still having DCO problems, would closing the PR trigger it to be re-opened? Or would we need to take a more direct approach in amending the commit?
….1695740971 Signed-off-by: Michael Valdron <[email protected]>
06b3292
to
f464071
Compare
@michael-valdron Yes indeed I did it manually to see any other issues that might occur. But in general we need to add a solution to our configuration for this issue. |
Is there an issue open to implement a solution to this? |
@michael-valdron atm I am in the process of monitoring the behaviour. Ill create an issue with all fixes needed tomorrow |
@michael-valdron Created devfile/api#1280 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I've tested all updated stacks with odo dev
locally and they were working after the update of the image
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, platform-engineering-bot, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
1-105.1684740145
->1-129.1695740971
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.