Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 #212

Merged

Conversation

platform-engineering-bot
Copy link
Contributor

@platform-engineering-bot platform-engineering-bot commented Oct 3, 2023

This PR contains the following updates:

Package Update Change
registry.access.redhat.com/ubi8/nodejs-16 patch 1-105.1684740145 -> 1-129.1695740971

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@thepetk thepetk force-pushed the renovate/registry.access.redhat.com-ubi8-nodejs-16-1.x branch from fb1f16b to 4d6b8fb Compare October 3, 2023 10:53
@platform-engineering-bot platform-engineering-bot changed the title Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129 Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 Oct 3, 2023
@platform-engineering-bot platform-engineering-bot force-pushed the renovate/registry.access.redhat.com-ubi8-nodejs-16-1.x branch from 4d6b8fb to 06b3292 Compare October 3, 2023 15:19
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepetk This one is still having DCO problems, would closing the PR trigger it to be re-opened? Or would we need to take a more direct approach in amending the commit?

@michael-valdron
Copy link
Member

@thepetk This one is still having DCO problems, would closing the PR trigger it to be re-opened? Or would we need to take a more direct approach in amending the commit?

Looks like you did a direct amend for this one: #213

@michael-valdron michael-valdron force-pushed the renovate/registry.access.redhat.com-ubi8-nodejs-16-1.x branch from 06b3292 to f464071 Compare October 3, 2023 16:45
@michael-valdron
Copy link
Member

@thepetk This one is still having DCO problems, would closing the PR trigger it to be re-opened? Or would we need to take a more direct approach in amending the commit?

Looks like you did a direct amend for this one: #213

Fixed

@thepetk
Copy link
Contributor

thepetk commented Oct 3, 2023

Looks like you did a direct amend for this one: #213

@michael-valdron Yes indeed I did it manually to see any other issues that might occur. But in general we need to add a solution to our configuration for this issue.

@michael-valdron
Copy link
Member

michael-valdron commented Oct 3, 2023

Looks like you did a direct amend for this one: #213

@michael-valdron Yes indeed I did it manually to see any other issues that might occur. But in general we need to add a solution to our configuration for this issue.

Is there an issue open to implement a solution to this?

@thepetk
Copy link
Contributor

thepetk commented Oct 3, 2023

Looks like you did a direct amend for this one: #213

@michael-valdron Yes indeed I did it manually to see any other issues that might occur. But in general we need to add a solution to our configuration for this issue.

Is there an issue open to implement a solution to this?

@michael-valdron atm I am in the process of monitoring the behaviour. Ill create an issue with all fixes needed tomorrow

@thepetk
Copy link
Contributor

thepetk commented Oct 4, 2023

Looks like you did a direct amend for this one: #213

@michael-valdron Yes indeed I did it manually to see any other issues that might occur. But in general we need to add a solution to our configuration for this issue.

Is there an issue open to implement a solution to this?

@michael-valdron atm I am in the process of monitoring the behaviour. Ill create an issue with all fixes needed tomorrow

@michael-valdron Created devfile/api#1280

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I've tested all updated stacks with odo dev locally and they were working after the update of the image

@openshift-ci openshift-ci bot added lgtm Looks good to me approved labels Oct 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, platform-engineering-bot, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@platform-engineering-bot platform-engineering-bot changed the title Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 - autoclosed Oct 5, 2023
@platform-engineering-bot platform-engineering-bot deleted the renovate/registry.access.redhat.com-ubi8-nodejs-16-1.x branch October 5, 2023 13:22
@thepetk thepetk restored the renovate/registry.access.redhat.com-ubi8-nodejs-16-1.x branch October 5, 2023 13:37
@thepetk thepetk reopened this Oct 5, 2023
@thepetk thepetk changed the title Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 - autoclosed Update registry.access.redhat.com/ubi8/nodejs-16 Docker tag to v1-129.1695740971 Oct 5, 2023
@thepetk thepetk merged commit 924c29d into main Oct 5, 2023
11 checks passed
@rm3l rm3l deleted the renovate/registry.access.redhat.com-ubi8-nodejs-16-1.x branch October 5, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants