Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s api #212

Merged
merged 1 commit into from
Jun 12, 2024
Merged

bump k8s api #212

merged 1 commit into from
Jun 12, 2024

Conversation

Kartikey-star
Copy link
Contributor

@Kartikey-star Kartikey-star commented May 27, 2024

This PR is aimed at making the changes required for openshift/console#13816.

The PR to bump the k8s api in devfile api is merged devfile/api#1545.
The current PR makes the required changes for library.

fixes devfile/api#1543

@michael-valdron
Copy link
Member

fixes devfile/api#1543

@michael-valdron
Copy link
Member

@Kartikey-star CI check seems to fail on Test_parseFromRegistry/should_fail_if_registryUrl_is_invalid.

Tried reproducing locally in debug mode as well with no luck:

"Get \"http://http//invalid.com/devfiles/notexist/\": dial tcp: lookup http: no such host" matches "Get .* dial tcp: lookup http: .*"

Also, retried CI check and it still fails, from what I can tell the CI check error is different:

"Get "http://http//invalid.com/devfiles/notexist/": dial tcp: lookup http on 127.0.0.53:53: server misbehaving"

We can open a issue to investigate this.

@michael-valdron
Copy link
Member

We can open a issue to investigate this.

devfile/api#1588

FYI @Kartikey-star

@thepetk
Copy link
Contributor

thepetk commented Jun 11, 2024

@Kartikey-star could you rebase your PR with the latest changes of the library repo?

@michael-valdron
Copy link
Member

fix for failure coming with #217

FYI @Kartikey-star

@michael-valdron
Copy link
Member

fix for failure coming with #217

FYI @Kartikey-star

@Kartikey-star Changes are merged, rebase your changes again and the check should pass now.

Signed-off-by: Kartikey-star <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kartikey-star, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 45a4cc4 into devfile:main Jun 12, 2024
5 checks passed
Jdubrick added a commit that referenced this pull request Aug 15, 2024
* update schema version to 2.2.2 for nodejs test child devfiles (#213)

Signed-off-by: Michael Valdron <[email protected]>

* add ubuntu server bypass error case for invalid registry urls (#217)

Signed-off-by: Michael Valdron <[email protected]>

* Fix parent version on test devfile (#216)

* Fix parent version on test devfile

Signed-off-by: thepetk <[email protected]>

* Update parent version

Signed-off-by: thepetk <[email protected]>

---------

Signed-off-by: thepetk <[email protected]>

* bump k8s api (#212)

Signed-off-by: Kartikey-star <[email protected]>

* update references to Go 1.21 in docs (#218)

Signed-off-by: Michael Valdron <[email protected]>

* Add support for 2.3.0 schema version (#219)

* updateApi.sh script includes newer schema versions

Signed-off-by: Michael Valdron <[email protected]>

* devfile 2.3.0 support

Signed-off-by: Michael Valdron <[email protected]>

* revert schema versions for testing older features

Signed-off-by: Michael Valdron <[email protected]>

---------

Signed-off-by: Michael Valdron <[email protected]>

* Bump github.com/docker/docker (#221)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.1+incompatible to 25.0.6+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v25.0.1...v25.0.6)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update readme for 2.3.0 schema (#222)

Signed-off-by: Jordan Dubrick <[email protected]>

---------

Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: Kartikey-star <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Co-authored-by: Theofanis Petkos <[email protected]>
Co-authored-by: Kartikey Mamgain <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devfile Library should be updated to support Go 1.21
3 participants