Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep gopls version to golang.org/x/tools/gopls v0.16.2 #207

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Dec 12, 2024

Gopls v0.17.0 was released recently on Dec 11, which breaks the UDI build with this error:

#20 6.448 go: golang.org/x/tools/gopls@latest: golang.org/x/tools/[email protected] requires go >= 1.23.1 (running go 1.22.7; GOTOOLCHAIN=local)

This PR updates the dockerfile to use gopls v0.16.2 which is compatible with go version 1.22.7.

To test this PR, run:

cd universal/ubi9 && DOCKER_BUILDKIT=1 docker image build --progress=plain -t quay.io/devfile/universal-developer-image:ubi9-latest .

and verify that the build succeeds.

Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, ibuziuk, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit b5dc4bf into devfile:main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants