Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Extended base class and fixed fatal errors #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DaSpors
Copy link

@DaSpors DaSpors commented Mar 9, 2015

We extended the SOAP base class with a method to allow re-use of authorized sessions.
Additionally the sessionHeader was added to the SOAP header without check for existance, so there was an empty header thus beeing invalid. This has been fixed.

DaSpors added 2 commits March 9, 2015 11:35
Added ContinueSession to avoid multiple login calls
@metadaddy
Copy link
Contributor

Looks good - thanks! One minor nit - function names should start with lower case, so could you change ContinueSession and RefreshToken to continueSession and refreshToken respectively?

Also, we need a contributor license agreement (CLA, very similar to Apache projects) to accept substantial contributions. Could you fill out the CLA doc, scan it, and send it to me at ppatterson (at) salesforce (dot) com?

@aaronbauman
Copy link

RefreshToken() adds an explicit dependency on curl, and uses REST API.
These changes should not be introduced to the SOAP client.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants