Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add talosctl via Github Releases #55

Merged
merged 2 commits into from
Oct 19, 2024
Merged

feat: add talosctl via Github Releases #55

merged 2 commits into from
Oct 19, 2024

Conversation

pl4nty
Copy link

@pl4nty pl4nty commented Oct 15, 2024

@koralowiec koralowiec self-requested a review October 18, 2024 19:01
koralowiec
koralowiec requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I left two request changes. If you have a question, feel free to ask!

src/talosctl/install.sh Outdated Show resolved Hide resolved
test/talosctl/scenarios.json Outdated Show resolved Hide resolved
@koralowiec koralowiec mentioned this pull request Oct 18, 2024
Merged
@pl4nty
Copy link
Author

pl4nty commented Oct 19, 2024

Thanks, I've added an n-1 version test (v1.8.0) along with a prerelease regex, and confirmed it's working in CI (installs v1.8.1). I'll send a PR for prerelease support in nanolayer shortly.

@pl4nty
Copy link
Author

pl4nty commented Oct 19, 2024

It would help to have a CONTRIBUTING.md or similar with guidance/prereqs too (like just), I could write a draft if you'd like?

@koralowiec
Copy link
Member

I have CONTRIBUTING.md on my to do list, but I would appreciate a PR from you! So if you have time to write it, them feel free to add it

@koralowiec
Copy link
Member

I created issue for CONTRIBUTING.md: #57
Please, just confirm there if I should assign you to it

@koralowiec koralowiec merged commit e715f29 into devcontainers-extra:main Oct 19, 2024
4 checks passed
@pl4nty pl4nty deleted the feat/add-talosctl branch October 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koralowiec koralowiec koralowiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pl4nty @koralowiec