Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hato-bot用おみくじセットアップをplugins/hato_mikujiに分離 #3713

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

fono09
Copy link
Collaborator

@fono09 fono09 commented Feb 23, 2024

#876 のおみくじ関係の修正

それ以外の修正は別のPRでやる

また、下記のように呼び分けている
Omikuji (library文脈)
HatoMikuji (hato-bot文脈)

fono09 added a commit that referenced this pull request Feb 23, 2024
…mikuji

formatが間違ってたので直してあげたよ! #3713
@fono09 fono09 force-pushed the fono/refactor-hato-mikuji branch 2 times, most recently from eef9c71 to 71a546b Compare February 23, 2024 12:30
@fono09 fono09 force-pushed the fono/refactor-hato-mikuji branch from 71a546b to 759a305 Compare February 23, 2024 12:44
@fono09 fono09 requested a review from massongit February 23, 2024 12:50
@massongit
Copy link
Member

massongit commented Feb 23, 2024

#876 の一部って理解で良いかしら?
そうだとすれば概要にIssue番号 ( #876 ) は書いてあるとよさそう。

@fono09 fono09 merged commit e48f047 into develop Feb 23, 2024
39 checks passed
@fono09 fono09 deleted the fono/refactor-hato-mikuji branch February 23, 2024 13:21
@fono09 fono09 self-assigned this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants