開発環境: ファイルに変更が加えられたらDockerイメージを再ビルドする #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massongit
requested review from
Goryudyuma
and removed request for
Goryudyuma
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://v10421-dot-hato-atama.an.r.appspot.com |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Goryudyuma
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://v10435-dot-hato-atama.an.r.appspot.com |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.hatenastaff.com/entry/2023/10/13/120000
開発環境において、
compose.ymlやDockerfile、Dockerfile内でCOPYされているファイルに変更が加えられたらDockerイメージを再ビルドするようにします。compose.ymlにdevelop.watchが含まれているとCIでのビルド時にエラーになるので、開発環境用のcompose.ymlをベースと実行用に分けています。なお、
server/Dockerfileは.dockerignoreに含まれている関係でwatch対象に含めていません。