Better handling of unsafe filenames #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See deshaw#346, The handling of unsafe Filenames is a bit weird as the safety is checked a bit too late in my opinion, and checked before the path is fully resolved. This tries to change this a bit by eing stricter on checking for safeness, and refactor the caching of import db to use Pathlib (which did not exists when FIlename was crreated). This is still a bit more complicated than it should and might need some cleanup later on. There is also a buch of "deprecated" code in a if True in this area, that would need propoer deprecation.
Carreau
force-pushed
the
fix-unsafe-filenames
branch
from
2219183 to
7272bdb
Compare
Carreau
force-pushed
the
fix-unsafe-filenames
branch
from
6eaf417 to
c5ddb8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #346,
The handling of unsafe Filenames is a bit weird as the safety is checked a bit too late in my opinion, and checked before the path is fully resolved.
This tries to change this a bit by eing stricter on checking for safeness, and refactor the caching of import db to use Pathlib (which did not exists when FIlename was crreated).
This is still a bit more complicated than it should and might need some cleanup later on.
There is also a buch of "deprecated" code in a if True in this area, that would need propoer deprecation.