Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional last executed date #94

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

banteg
Copy link
Contributor

@banteg banteg commented Sep 13, 2023

add a showDate privacy setting that allows to hide the last executed date.

with it enabled, Last executed at <date> in <time> becomes Last executed in <time>.

it allows to safely share screenshots of your notebooks without leaking the timezone you are in.

@mlucool
Copy link
Member

mlucool commented Sep 13, 2023

Hi @banteg thanks for the PR. Can you please sign the CLA before review? https://github.com/deshaw/jupyterlab-execute-time/blob/master/CONTRIBUTING.md

@banteg
Copy link
Contributor Author

banteg commented Sep 13, 2023

sure, done

Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banteg this PR will need a rebase because #93 edited some of the same lines. I also left a comment on description of the proposed setting. Otherwise it looks good to me.

schema/settings.json Outdated Show resolved Hide resolved
@banteg
Copy link
Contributor Author

banteg commented Sep 13, 2023

rebased

Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @banteg, looks good to me.

@krassowski krassowski merged commit 597580e into deshaw:master Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants