Yaswanth/Added input props in dropdown component #60
Conversation
| @@ -89,7 +89,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
Most of the files currently are utilizing the px unit rather than rem. Let's keep it consistent throughout the whole project by using px as of now 👍🏼
There was a problem hiding this comment.
Yes.I am creating other PR to address these comments.Thanks
| className={className} | ||
| disabled={disabled} |
There was a problem hiding this comment.
You dont need to specify these cause its already default component props. You already have {...rest} passed in the bottom, it will do the job for you
There was a problem hiding this comment.
Yes.I am creating other PR to address these comments.Thanks
| className, | ||
| disabled, |
| name: InputProps['name']; | ||
| onChange?: (inputValue: string) => void; | ||
| onSearch?: (inputValue: string) => void; | ||
| onSelect: (value: string) => void; | ||
| value?: InputProps['value']; | ||
| variant?: 'comboBox' | 'prompt'; |
There was a problem hiding this comment.
@yaswanth-deriv you should fix the variants as well.prompt variation is the one where you can type in it.
|
🎉 This PR is included in version 1.5.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I needed to include the input component's props in the dropdown component and update the onChange prop to onInputChange.