Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farabi/feq-2693/fix-localisation-with-account-switcher-tabs #262

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Farabi/feq-2693/fix-localisation-with-account-switcher-tabs #262

merged 3 commits into from
Oct 15, 2024
+17 −7

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • Fixed localisation issue with account switcher tabs by passing tabsLabels as props, replacing the static strings.

shayan-deriv
shayan-deriv reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@shayan-deriv shayan-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update the storybook as well?

@shayan-deriv shayan-deriv merged commit ed00699 into deriv-com:master Oct 15, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.36.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayan-deriv shayan-deriv shayan-deriv approved these changes

@rupato-deriv rupato-deriv rupato-deriv approved these changes

@sandeep-deriv sandeep-deriv sandeep-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farabi-deriv @sandeep-deriv @rupato-deriv @shayan-deriv