Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lubega / Fix dropdown UI discrepancies #222

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Lubega / Fix dropdown UI discrepancies #222

merged 6 commits into from
Jul 1, 2024

Conversation

lubega-deriv
Copy link
Collaborator

Changes:

  • Fix small UI discrepancies with dropdown component
  • Added right margin for left icon and top margin for dropdown list

Before:

Screenshot 2024-07-01 at 1 38 20 PM

After:

Screenshot 2024-07-01 at 1 38 11 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9738948838

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.053%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dropdown/index.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 9657086156: 0.0%
Covered Lines: 227
Relevant Lines: 351
💛 - Coveralls

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 1, 2024 •
edited
Loading

Deploying deriv-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: a10dfad
Status: ✅  Deploy successful!
Preview URL: https://fac87f84.deriv-ui.pages.dev
Branch Preview URL: https://lubega-dropdown-ui-fixes.deriv-ui.pages.dev

View logs

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9739125377

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.053%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dropdown/index.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 9657086156: 0.0%
Covered Lines: 227
Relevant Lines: 351
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9739292646

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.053%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dropdown/index.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 9657086156: 0.0%
Covered Lines: 227
Relevant Lines: 351
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9739438839

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 59.894%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dropdown/index.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 9657086156: -0.2%
Covered Lines: 227
Relevant Lines: 351
💛 - Coveralls

@shayan-deriv shayan-deriv merged commit ed4a009 into main Jul 1, 2024
6 checks passed
@shayan-deriv shayan-deriv deleted the lubega/dropdown-ui-fixes branch July 1, 2024 08:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

🎉 This PR is included in version 1.29.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9739785809

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.053%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dropdown/index.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 9657086156: 0.0%
Covered Lines: 227
Relevant Lines: 351
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nada-deriv nada-deriv nada-deriv left review comments

@aizad-deriv aizad-deriv aizad-deriv left review comments

@yashim-deriv yashim-deriv yashim-deriv left review comments

@jia-deriv jia-deriv jia-deriv approved these changes

@shayan-deriv shayan-deriv shayan-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lubega-deriv @coveralls @yashim-deriv @shayan-deriv @aizad-deriv @nada-deriv @jia-deriv