Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shayan/feq 2183/implement account switcher #195

Merged
merged 17 commits into from
May 15, 2024

Conversation

shayan-deriv
Copy link
Contributor

@shayan-deriv shayan-deriv commented May 13, 2024

Usage Example:

                        <AccountSwitcher
                            activeAccount={activeAccount}
                        >
                            <AccountSwitcher.Tab title="Real">

                                <AccountSwitcher.AccountsPanel
                                    isOpen
                                    title="EU Accounts"
                                >
                                    {accountsList
                                        .map((account) => (
                                            <AccountSwitcher.AccountsItem
                                                key={account.loginid}
                                                account={account}
                                                onSelectAccount={() => {}}
                                            />
                                        ))}
                                </AccountSwitcher.AccountsPanel>

                                <Divider color="#f2f3f4" height="4px" />

                                <AccountSwitcher.AccountsPanel title="Non-EU">
                                    {accountsList
                                        .map((account) => (
                                            <AccountSwitcher.AccountsItem
                                                key={account.loginid}
                                                account={account}
                                                onSelectAccount={() => {}}
                                            />
                                        ))}
                                </AccountSwitcher.AccountsPanel>

                                <Divider color="#f2f3f4" height="4px" />

                                <AccountSwitcher.TotalAsset
                                    title="Total assets"
                                    description="test description text comes here"
                                    value="10,021 USD"
                                />

                                <Divider color="#f2f3f4" height="4px" />

                                <AccountSwitcher.TradersHubLink>
                                    Looking for CFD?{" "}
                                </AccountSwitcher.TradersHubLink>

                                <Divider color="#f2f3f4" height="4px" />

                                <AccountSwitcher.Footer>
                                    this is a footer
                                </AccountSwitcher.Footer>

                            </AccountSwitcher.Tab>

                            <AccountSwitcher.Tab title="Demo">
                                test 2
                            </AccountSwitcher.Tab>

                        </AccountSwitcher>

Screen Record:
https://github.com/deriv-com/ui/assets/100833613/e86b5945-503a-4e80-9022-32578c640c90

Copy link

cloudflare-workers-and-pages bot commented May 13, 2024

Deploying deriv-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd8754e
Status: ✅  Deploy successful!
Preview URL: https://7d6ee450.deriv-ui.pages.dev
Branch Preview URL: https://shayan-feq-2183-implement-ac.deriv-ui.pages.dev

View logs

Copy link

github-actions bot commented May 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@shayan-deriv shayan-deriv marked this pull request as ready for review May 13, 2024 07:29
Comment on lines +43 to +55
.ReactModal__Overlay {
opacity: 0;
}

.ReactModal__Overlay--after-open{
opacity: 1;
transition: opacity 200ms ease-in-out;
}

.ReactModal__Overlay--before-close{
opacity: 0;
transition: opacity 400ms ease-in-out;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are for modal animation in mobile

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9091164456

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.905%

Totals Coverage Status
Change from base Build 9090595578: 0.0%
Covered Lines: 218
Relevant Lines: 346

💛 - Coveralls

@shayan-deriv shayan-deriv requested a review from nada-deriv May 15, 2024 03:48
}


}
Copy link
Collaborator

@nada-deriv nada-deriv May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be the prettier didn't run ..

@shayan-deriv shayan-deriv merged commit 152cf41 into main May 15, 2024
6 checks passed
@shayan-deriv shayan-deriv deleted the shayan/feq-2183/implement-account-switcher branch May 15, 2024 07:50
Copy link

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants