Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot alert fix on package braces #17

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

aqib-deriv
Copy link
Collaborator

@aqib-deriv aqib-deriv commented Nov 29, 2024

https://app.clickup.com/t/20696747/CICD-1164

Summary:
Uncontrolled resource consumption in braces #25

Steps to fix:
Run npm audit fix to patch versions of affected packages

@chylli-deriv
Copy link

It need a build command to update dist files.

 npm run build
 npm run package
 git add dist
 git commit -m 'rebuild dist'

@aqib-deriv
Copy link
Collaborator Author

aqib-deriv commented Nov 29, 2024

It need a build command to update dist files.

 npm run build
 npm run package
 git add dist
 git commit -m 'rebuild dist'

thanks @chylli-deriv, if you don't mind, can I ask why do we have to perform these steps manually here?

@chylli-deriv
Copy link

It need a build command to update dist files.

 npm run build
 npm run package
 git add dist
 git commit -m 'rebuild dist'

thanks @chylli-deriv, if you don't mind, can I ask why do we have to perform these steps manually here?

if you are asking why: the dist files need to be updated after we change source code, and then it can be used outside.
If you are asking why do it manually: we copied from the original repo and didn't change that. the original code is that.

@mukesh-deriv mukesh-deriv merged commit a1364ab into deriv-com:main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants