Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OIDC flow to SmartTrader #855

Closed
wants to merge 125 commits into from
Closed

Added OIDC flow to SmartTrader #855

wants to merge 125 commits into from

Conversation

adrienne-deriv
Copy link
Contributor

@adrienne-deriv adrienne-deriv commented Nov 19, 2024 •
edited
Loading

Changes:
Added OIDC flow to SmartTrader. This involves:

  • A new Callback page at /en/callback route which will call authorize and set the client.accounts
  • Deprecating and removing Deriv's legacy iframe localstorage-sync
  • Adding and checking the cookie logged_state to automatically SSO the user when they have previously logged in from other applications
Screen.Recording.2024-11-27.at.5.50.56.PM.mov

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@adrienne-deriv adrienne-deriv marked this pull request as ready for review November 19, 2024 05:46
@adrienne-deriv adrienne-deriv requested a review from a team as a code owner November 19, 2024 05:46
@adrienne-deriv adrienne-deriv changed the title Added OIDC flow to SmartTrader Added OIDC flow to SmartTrader [POC] Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Name Result
Build status Failed ❌
Action URL Visit Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amam-deriv amam-deriv amam-deriv approved these changes

@hasan-deriv hasan-deriv hasan-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrienne-deriv @hasan-deriv @amam-deriv @thisyahlen-deriv