feat: add remote toggle for livechat and whatsapp #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
…livechat-feature-toggle
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
…livechat-feature-toggle
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
kate-deriv
reviewed
Oct 28, 2024
src/javascript/app/base/header.js
Outdated
| const topbar_whatsapp = getElementById('topbar-whatsapp'); | ||
| const whatsapp_mobile_drawer = getElementById('whatsapp-mobile-drawer'); | ||
|
|
||
| if (cs_chat_livechat) { |
There was a problem hiding this comment.
I think this part can be improved, as the logic with applying inline-flex and none is similar.
Something like this:
const updateVisibility = ({condition, element_1, element_2}) => {
const display_type= condition ? 'inline-flex' : 'none';
element_1.style.display = display_type;
element_2.style.display = display_type;
}
updateVisibility({condition: cs_chat_livechat, element_1: mobile_menu_livechat, element_2: livechat});
updateVisibility({condition: cs_chat_whatsapp, element_1: topbar_whatsapp, element_2: whatsapp_mobile_drawer});
kate-deriv
reviewed
Oct 28, 2024
src/javascript/app/base/header.js
Outdated
| @@ -40,7 +41,7 @@ const Header = (() => { | |||
| fnc_enter: ['requestFullscreen', 'webkitRequestFullscreen', 'mozRequestFullScreen', 'msRequestFullscreen'], | |||
| fnc_exit : ['exitFullscreen', 'webkitExitFullscreen', 'mozCancelFullScreen', 'msExitFullscreen'], | |||
| }; | |||
|
|
|||
kate-deriv
reviewed
Oct 28, 2024
|
|
||
| const getRemoteConfig = async (enabled = false) => { | ||
| isEnabled = enabled; | ||
| if (isEnabled) { |
There was a problem hiding this comment.
Not sure, but will it work?
const getRemoteConfig = async (enabled = false) => {
if (enabled) await fetchAndUpdateData();
return { data };
}
There was a problem hiding this comment.
can but i still have to update isEnabled. hence was using isEnabled.
There was a problem hiding this comment.
aaa, okay, got it, then ignore me comment please
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
kate-deriv
approved these changes
Oct 28, 2024
akmal-deriv
approved these changes
Oct 29, 2024
nijil-deriv
approved these changes
Oct 29, 2024
henry-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
|
Preview Link: https://pr-833.smarttrader-preview.pages.dev
|
ahmadtaimoor-deriv
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change