Adrienne / Integrate Hydra authentication #821

adrienne-deriv · 2024-09-24T05:40:50Z

Changes:

Setup @deriv-com/analytics to integrate feature toggling from Growthbook for enabling/disabling Hydra authentication flow
Setup @deriv-com/auth-client to integrate the new Hydra authentication flow
Refactored the Deriv iframe localstorage-sync to be enabled/disabled based on the feature flag from Growthbook

Type of change

adrienne-deriv · 2024-09-26T03:50:13Z

src/javascript/app/pages/deriv_iframe.jsx

+    const isAuthEnabled = isOAuth2Enabled();
+
+    if (!isAuthEnabled) ReactDOM.render(<DerivIFrame />, document.getElementById('deriv_iframe'));
+};


I moved the DerivIframe component to the javascript folder so that it can be conditionally rendered to be included/excluded based on the feature flag returned by isOauth2Enabled.
If the Hydra authentication is enabled, we will not be using the Deriv iframe to sync login states anymore

so we want to disable syncing in certain scenarios?

We only disable it when the Hydra authentication feature flag is enabled, which we turn on/off from Growthbook

Because one of our aim for this feature is to remove the use of Deriv iframe sync entirely and migrate these syncing logic into the Hydra service, which is on BE's side

src/javascript/app/base/header.js

adrienne-deriv · 2024-09-26T03:53:16Z

src/javascript/_common/base/__tests__/client_base.js

+    isOAuth2Enabled: function() {
+        return false
+    }
+});


This is to resolve test case issues where @deriv-com/analytics is using Growthbook module which uses MutationObserver, in which Mocha doesn't recognise and is unable to mock it

…rkflow

amam-deriv · 2024-09-26T06:18:10Z

.github/workflows/release_production.yml

@@ -22,6 +23,9 @@ jobs:
        uses: "./.github/actions/build"
        with:
          target: production
+          RUDDERSTACK_KEY:  ${{ vars.RUDDERSTACK_KEY }}
+          GROWTHBOOK_DECRYPTION_KEY: ${{ secrets.GROWTHBOOK_DECRYPTION_KEY }}


[Q] why is this on secrets but client key is on vars?

The Rudderstack and Growthbook client keys are public, you can see them on the network requests and window._growthbook instances, but only the decryption keys are private

amam-deriv · 2024-09-27T10:42:56Z

src/javascript/_common/auth.js

+export const getOAuthOrigin = () => {
+    const { appId, serverUrl } = getServerInfo();
+
+    const oauthUrl = appId && serverUrl ? `https://${serverUrl}` : DEFAULT_OAUTH_ORIGIN_URL;


[Q] whats appId check used here for?

Its just an extra check to ensure we have the app ID and server URL before returning the origin url

amam-deriv · 2024-09-27T10:44:12Z

src/javascript/_common/auth.js

+        const allowedOrigin = getOAuthOrigin();
+        if (allowedOrigin === event.origin) {
+            if (event.data === 'logout_complete') {
+                await onWSLogoutAndRedirect();


[R] please wrap await function in a try catch block

amam-deriv · 2024-09-27T10:45:28Z

src/javascript/_common/auth.js

+
+            setTimeout(() => {
+                onWSLogoutAndRedirect();
+            }, 10000);


[M] static data can be put in a constant variable on top of the file

src/javascript/app/base/header.js

amam-deriv · 2024-09-27T10:49:29Z

src/javascript/app/hooks/growthbook.js

+        let checksCounter = 0;
+        const analyticsInterval = setInterval(() => {
+            // Check if the analytics instance is available for 10 seconds before setting the feature flag value
+            if (checksCounter > 20) {


not sure why is this required, but i see that this is carried over implementation.

No this hook file is no longer needed, will remove it for now 😅

amam-deriv · 2024-09-27T10:49:56Z

src/javascript/app/hooks/growthbook.js

+                setIsGBLoaded(true);
+                clearInterval(analyticsInterval);
+            }
+        }, 500);


[M] this can become 1000 and checksCounter > 10?

amam-deriv · 2024-09-30T09:13:59Z

src/javascript/_common/auth.js

+
+    const serverUrl = LocalStorageUtils.getValue(LocalStorageConstants.configServerURL) || localStorage.getItem('config.server_url') || 'oauth.deriv.com';
+
+    const appId = LocalStorageUtils.getValue(LocalStorageConstants.configAppId);


[Q] is the value always available that we don't need a fallback?

amam-deriv

LGTM!

…hydra-feature

…trader into setup-hydra-feature

github-actions · 2024-10-16T02:02:58Z

Preview Link: https://pr-821.smarttrader-preview.pages.dev

Name	Result
Build status	Completed ✅
Preview URL	Visit Preview
Action URL	Visit Action

adrienne-deriv added 8 commits September 24, 2024 12:40

feat: added analytics to smarttrader

753bb65

feat: added auth-client library

de69d69

chore: generate test link

be1724f

chore: generate test link

d28a2d8

chore: resolved eslint issues

893884d

chore: fixed issue with deriv analytics being part of mocha test

5dee70e

chore: skip tests to generate a test link temporarily

b05de9c

chore: skip tests to generate a test link temporarily

157fa60

adrienne-deriv force-pushed the setup-hydra-feature branch from a120881 to 157fa60 Compare September 24, 2024 09:04

adrienne-deriv added 2 commits September 25, 2024 17:01

chore: finally fixed test cases :)

fbe651f

chore: reverted prettier formatting

690317d

adrienne-deriv changed the title ~~Setup auth-client for Hydra authentication~~ Adrienne / Integrate Hydra authentication Sep 26, 2024

adrienne-deriv commented Sep 26, 2024

View reviewed changes

src/javascript/app/base/header.js Show resolved Hide resolved

adrienne-deriv commented Sep 26, 2024

View reviewed changes

adrienne-deriv marked this pull request as ready for review September 26, 2024 03:53

adrienne-deriv requested a review from a team as a code owner September 26, 2024 03:53

minor: added environment variables for analytics to github actions wo…

36bfba6

…rkflow

adrienne-deriv temporarily deployed to Production September 26, 2024 05:24 — with GitHub Actions Inactive

chore: used curly braces for secrets and envs in workflow

5a90f66

adrienne-deriv temporarily deployed to Production September 26, 2024 05:35 — with GitHub Actions Inactive

chore: used curly braces for secrets and envs in workflow

2601575

adrienne-deriv temporarily deployed to Production September 26, 2024 05:43 — with GitHub Actions Inactive

shayan-deriv approved these changes Sep 27, 2024

View reviewed changes

ahmadtaimoor-deriv previously approved these changes Sep 27, 2024

View reviewed changes

thisyahlen-deriv approved these changes Sep 27, 2024

View reviewed changes

amam-deriv requested changes Sep 27, 2024

View reviewed changes

chore: resolved pr comments

1105aa0

adrienne-deriv dismissed ahmadtaimoor-deriv’s stale review via 1105aa0 September 30, 2024 09:00

adrienne-deriv temporarily deployed to Production September 30, 2024 09:00 — with GitHub Actions Inactive

thisyahlen-deriv approved these changes Sep 30, 2024

View reviewed changes

amam-deriv reviewed Sep 30, 2024

View reviewed changes

amam-deriv approved these changes Sep 30, 2024

View reviewed changes

10202f8

adrienne-deriv had a problem deploying to Development October 3, 2024 03:03 — with GitHub Actions Error

Merge branch 'master' of github.com:deriv-com/smarttrader into setup-…

4e9ade8

…hydra-feature

adrienne-deriv temporarily deployed to Production October 3, 2024 03:06 — with GitHub Actions Inactive

adrienne-deriv temporarily deployed to Development October 3, 2024 03:06 — with GitHub Actions Inactive

chore: removed unrelated changes to workflow

4286a60

adrienne-deriv had a problem deploying to Development October 3, 2024 03:10 — with GitHub Actions Error

adrienne-deriv added 2 commits October 3, 2024 11:10

chore: removed unrelated changes to workflow

bad20f6

Merge branch 'setup-hydra-feature' of github.com:adrienne-deriv/smart…

b339eda

…trader into setup-hydra-feature

adrienne-deriv temporarily deployed to Development October 3, 2024 03:11 — with GitHub Actions Inactive

chore: add new line to regenerate test link

b3df698

adrienne-deriv had a problem deploying to Development October 3, 2024 05:48 — with GitHub Actions Failure

chore: add new line to regenerate test link

7c03bb1

adrienne-deriv temporarily deployed to Development October 3, 2024 05:51 — with GitHub Actions Inactive

chore: removed decryption key

0deec9e

adrienne-deriv had a problem deploying to Development October 3, 2024 06:25 — with GitHub Actions Failure

adrienne-deriv added 2 commits October 3, 2024 14:26

chore: removed decryption key

4a93343

Merge branch 'setup-hydra-feature' of github.com:adrienne-deriv/smart…

03d6000

…trader into setup-hydra-feature

adrienne-deriv temporarily deployed to Development October 3, 2024 06:27 — with GitHub Actions Inactive

chore: update package-lock and default app id fallback

3b5332b

adrienne-deriv temporarily deployed to Development October 16, 2024 02:00 — with GitHub Actions Inactive

thisyahlen-deriv approved these changes Oct 16, 2024

View reviewed changes

ahmadtaimoor-deriv approved these changes Oct 17, 2024

View reviewed changes

ahmadtaimoor-deriv merged commit 28de573 into deriv-com:master Oct 17, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adrienne / Integrate Hydra authentication #821

Adrienne / Integrate Hydra authentication #821

adrienne-deriv commented Sep 24, 2024 •

edited

Loading

adrienne-deriv Sep 26, 2024

henry-deriv Sep 26, 2024

adrienne-deriv Sep 26, 2024

adrienne-deriv Sep 26, 2024

adrienne-deriv Sep 26, 2024

amam-deriv Sep 26, 2024

adrienne-deriv Sep 30, 2024

amam-deriv Sep 27, 2024

adrienne-deriv Sep 30, 2024

amam-deriv Sep 27, 2024

amam-deriv Sep 27, 2024

amam-deriv Sep 27, 2024

adrienne-deriv Sep 30, 2024

amam-deriv Sep 27, 2024

amam-deriv Sep 30, 2024

amam-deriv left a comment

github-actions bot commented Oct 16, 2024


		const serverUrl = LocalStorageUtils.getValue(LocalStorageConstants.configServerURL) \|\| localStorage.getItem('config.server_url') \|\| 'oauth.deriv.com';

		const appId = LocalStorageUtils.getValue(LocalStorageConstants.configAppId);

Adrienne / Integrate Hydra authentication #821

Adrienne / Integrate Hydra authentication #821

Conversation

adrienne-deriv commented Sep 24, 2024 • edited Loading

Type of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amam-deriv left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024

adrienne-deriv commented Sep 24, 2024 •

edited

Loading