Prince/Purchase section refactor #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-deriv
suggested changes
Aug 14, 2024
maryia-deriv
suggested changes
Aug 14, 2024
| <div className='purchase-body-box'> | ||
| <div className='purchase-amount-box'> | ||
| <div className='purchase-amount-info-box'> | ||
| <Text size='md'>{localize('Stake')}:</Text> |
There was a problem hiding this comment.
Suggested change
| <Text size='md'>{localize('Stake')}:</Text> | |
| <Text>{localize('Stake')}:</Text> |
nit-pick: not sure if it's in scope of this PR but size='md' can be removed from all Text's as it's a default value :)
Nuzhy-Deriv
reviewed
Aug 15, 2024
| @@ -191,15 +191,15 @@ export const FormComponent = () => { | |||
| options={start_dates.options} | |||
| value={findTextByValue(start_dates.options, date_start)} | |||
| onUpdate={updateFormField} | |||
| elementId='date_start' | |||
| element_id='date_start' | |||
There was a problem hiding this comment.
please help to update the elementId prop to element_id in DropdownComponent as well. This can break the functionality.
There was a problem hiding this comment.
For DropdownComponent and NumbersDropdown I kept it elementId because it's a prop.
There was a problem hiding this comment.
@prince-deriv I think you missed to revert the change here.
There was a problem hiding this comment.
@Nuzhy-Deriv please check one more time
Nuzhy-Deriv
reviewed
Aug 15, 2024
Nuzhy-Deriv
reviewed
Aug 15, 2024
Nuzhy-Deriv
reviewed
Aug 15, 2024
Nuzhy-Deriv
reviewed
Aug 15, 2024
Nuzhy-Deriv
approved these changes
Aug 16, 2024
maryia-deriv
suggested changes
Aug 16, 2024
|
Preview Link: https://pr-800.smarttrader-preview.pages.dev
|
maryia-deriv
approved these changes
Aug 19, 2024
balakrishna-deriv
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.