Prince/update webpack config to load css from quill library #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-deriv
reviewed
Jun 4, 2024
| @@ -62,7 +62,7 @@ const Layout = () => { | |||
| } | |||
|
|
|||
| return ( | |||
| <html> | |||
| <html className='light'> | |||
There was a problem hiding this comment.
@prince-deriv i know there is no dark theme for SmartTrader at the moment. But it doesn't feel right to hard-code 'light' right here. Can we please make it dynamic, or use some config for controlling whether it's light or dark?
There was a problem hiding this comment.
Sure @maryia-deriv I will check a way to store it somewhere
|
Preview Link: https://pr-657.smarttrader-preview.pages.dev
|
Comment on lines
+11
to
+13
| - name: Install dependencies | ||
| run: npm install | ||
| shell: bash |
There was a problem hiding this comment.
there is a separate action for npm install here -.github/actions/npm_install/action.yml. Can you make the changes in that file if needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on integrating the Quill UI library seamlessly into Smarttrader, optimizing its performance and compatibility. Here's a summary of the key modifications:
Transpilation Refinement:Enhanced the transpilation process of the Quill UI library to ensure smooth integration within Smarttrader. This involved adjusting configurations to align with Smarttrader's requirements and improve overall compatibility.Package.json Update:Updated the Quill UI package.json to conform to Smarttrader's specifications. This included setting the correct module type and defining the main entry point for better integration.CSS Consolidation:Consolidated all CSS files from the Quill UI library into a single file during transpilation. This streamlines the CSS import process and resolves any issues associated with importing CSS files within the Quill UI package.Bundle Size Impact:With these optimizations, there's a 10% increase in Smarttrader's bundle size, from26.6 MBto29.4 MB. Despite the increase, the benefits of improved integration and performance justify the adjustment.Dependency Management:Added necessary dependencies such as css-loader and style-loader to parse and resolve CSS imports within the library. This ensures smoother handling of CSS content during integration.Theme Setup:Set up the default Quill UI theme to light, enhancing the overall visual consistency and user experience within Smarttrader.