chore: added comments and test remove webpack alias

deriv-com · Nov 27, 2024 · 46228db · 46228db
1 parent 7980d38
commit 46228db
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/build/webpack/config_common.js b/build/webpack/config_common.js
@@ -1,4 +1,3 @@
-const path = require('path');
 const TerserPlugin = require('terser-webpack-plugin');
 const publicPathFactory = require('./helpers').publicPathFactory;
 
@@ -30,9 +29,6 @@ const commonConfig = (grunt) => ({
     },
     resolve: {
         extensions: ['.js', '.jsx'],
-        alias: {
-            'react/jsx-runtime': 'react/jsx-runtime.js',
-        },
     },
     module: {
         rules: [

diff --git a/src/javascript/_common/auth.js b/src/javascript/_common/auth.js
@@ -170,6 +170,8 @@ export const requestSingleSignOn = async () => {
     const isGrowthbookLoaded = Analytics.isGrowthbookLoaded();
     if (!isGrowthbookLoaded) {
         let retryInterval = 0;
+        // this interval is to check if Growthbook is already initialised.
+        // If not, keep checking it (max 10 times) and SSO if conditions are met
         const interval = setInterval(() => {
             if (retryInterval > 10) {
                 clearInterval(interval);