Use current instance method for RPC calls #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this would take a snapshot of all the RPC method coderefs, and use those when handling any incoming RPC calls. The downside of this approach is that it leads to surprising behaviour if you try to override the RPC method with something else later, for example in a method attribute. We don't really gain anything by doing this - Perl already caches method calls. This commit therefore changes the behaviour to a standard method call keyed by the method name, meaning each RPC call will use whichever method is in the package symbol table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this would take a snapshot of all the RPC method coderefs, and use those when handling any incoming RPC calls.
The downside of this approach is that it leads to surprising behaviour if you try to override the RPC method with something else later, for example in a method attribute.
We don't really gain anything by doing this - Perl already caches method calls. This commit therefore changes the behaviour to a standard method call keyed by the method name, meaning each RPC call will use whichever method is in the package symbol table.