Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle stream creation race condition #341

Merged

Conversation

tom-binary
Copy link
Contributor

When multiple workers start up at the same time, the create-group-then-delete-it logic needed for Redis stream creation can end up interleaved, e.g. two CREATEs then two DESTROYs. Redis will dutifully throw an error at that point because you asked it to delete something which has already gone.

In our case, that's fine - we only need to clean up the unused group, we don't care who deleted it.

@tom-binary tom-binary merged commit a957ac0 into deriv-com:master Sep 5, 2024
1 check passed
@tom-binary tom-binary deleted the bugfix/stream_creation_race branch September 5, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant