feature/configurable_backlog #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we have lagged too far behind - or could not use approximate algorithm to remove enough items to be useful
…er allowed backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
Emitters to request a specific queue length, viamax_len. This is then used when deciding when to pause or clean up, and allows shorter/longer backlog than the10kdefault.To make this useful, the cleanup via
XTRIMnow applies the cleanup in batches, to avoid locking the server for extended amounts of time on larger streams. It also applies exact cleanup if the approximate cleanup couldn't find anything to remove and we're blocked waiting for progress, so that smaller streams can be used without deadlock.