Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niloofar/ Footer tests and improvements #84

Merged
merged 6 commits into from
May 30, 2024
Merged

Niloofar/ Footer tests and improvements #84

merged 6 commits into from
May 30, 2024

Conversation

niloofar-deriv
Copy link
Contributor

This PR includes:

  • Footer components tests
  • UI updates base on the production
  • Some clean code and improvements

nada-deriv
nada-deriv reviewed May 29, 2024
View reviewed changes
src/constants/url.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview Link: https://niloofar-footer-test.deriv-p2p.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@ali-hosseini-deriv ali-hosseini-deriv merged commit e5b3c54 into deriv-com:master May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nada-deriv nada-deriv nada-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv ali-hosseini-deriv approved these changes

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@ameerul-deriv ameerul-deriv Awaiting requested review from ameerul-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niloofar-deriv @ali-hosseini-deriv @ameerul-deriv @nada-deriv