fix: blocked message for temp barred user, green save button for ad details #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nada-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
matin-deriv
reviewed
May 27, 2024
| }: TMyProfileCounterpartiesTableRowRendererProps) => ( | ||
| <MyProfileCounterpartiesTableRow id={id!} isBlocked={isBlocked} nickname={name!} /> | ||
| <MyProfileCounterpartiesTableRow | ||
| id={id!} |
There was a problem hiding this comment.
Can you explain this assertion if the type is optional for id
There was a problem hiding this comment.
its not needed actually.. i removed it from name.. but forgot to remove it from id.. updated it 👍
|
Preview Link: https://nada-bug-fixes.deriv-p2p.pages.dev
|
ameerul-deriv
approved these changes
May 27, 2024
matin-deriv
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked Message for temporarily barred users
https://github.com/deriv-com/p2p/assets/122768621/62e73280-6718-411a-8850-bdff59c8b846
Green save button when saving ad details
Refactored BlockUnblockUserModal to use modal from deriv-com/ui instead of react-modal
Avatar resize issue fixed
Screen.Recording.2024-05-24.at.4.57.04.PM.mov
font issues