Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shayan/feq 2226/implement header component #77

Merged
merged 18 commits into from
May 29, 2024
Merged

Shayan/feq 2226/implement header component #77

merged 18 commits into from
May 29, 2024

Conversation

shayan-deriv
Copy link
Contributor

@shayan-deriv shayan-deriv commented May 24, 2024 •
edited
Loading

changes:

  • implemented header components including:
    • platform switcher
    • menu items
    • notification icon
    • account settings icon
    • account switcher

what's left:

  • match the styles with production
  • add notification drop-down
  • add skeleton loader

@nada-deriv
Copy link
Contributor

@shayan-deriv could you please check the build failure?

@github-actions GitHub Actions
Copy link

Preview Link: https://shayan-feq-2226-impl.deriv-p2p.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@matin-deriv matin-deriv merged commit 270088b into deriv-com:master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nada-deriv nada-deriv nada-deriv left review comments

@niloofar-deriv niloofar-deriv niloofar-deriv left review comments

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

@matin-deriv matin-deriv matin-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shayan-deriv @nada-deriv @matin-deriv @niloofar-deriv @ameerul-deriv