[FEQ]-[P2PS]- nada/fix: console error, firefox testlink, ellipsis issue, character count #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nada-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
...mponents/PaymentMethodForm/PaymentMethodFormModalRenderer/PaymentMethodFormModalRenderer.tsx
Show resolved
Hide resolved
src/pages/my-profile/screens/PaymentMethods/PaymentMethodsEmpty/PaymentMethodsEmpty.tsx
Outdated
Show resolved
Hide resolved
matin-deriv
reviewed
May 24, 2024
matin-deriv
approved these changes
May 24, 2024
src/pages/my-profile/screens/PaymentMethods/PaymentMethodsEmpty/PaymentMethodsEmpty.tsx
Outdated
Show resolved
Hide resolved
niloofar-deriv
approved these changes
May 24, 2024
|
Preview Link: https://nada-advertiser-regi.deriv-p2p.pages.dev
|
niloofar-deriv
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link keep crashing in Firefox
Missing character count on Ad details
Elipsis moves when selecting Payment Method
Console errors
Missing Translations
Added Block user Tooltip and modal in myprofile page
Myprofile ui scroll issues
Screen.Recording.2024-05-23.at.4.47.37.PM.mov
Missing rating score
Tabs my ads title fix
