Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: check translation" #59

Merged
merged 1 commit into from
May 9, 2024
Merged

Revert "chore: check translation" #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/AdvertsTableRow/AdvertsTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import { generateEffectiveRate, getCurrentRoute } from '@/utils';
import { LabelPairedChevronRightMdRegularIcon } from '@deriv/quill-icons';
import { useExchangeRates } from '@deriv-com/api-hooks';
import { Localize } from '@deriv-com/translations';
import { Button, Text, useDevice } from '@deriv-com/ui';
import './AdvertsTableRow.scss';

Expand Down Expand Up @@ -50,7 +49,7 @@
target_currencies: [local_currency],
});
}
}, [local_currency]);

Check warning on line 52 in src/components/AdvertsTableRow/AdvertsTableRow.tsx

View workflow job for this annotation

GitHub Actions / build_to_cloudflare_pages 

React Hook useEffect has a missing dependency: 'subscribeRates'. Either include it or remove the dependency array

const Container = isMobile ? 'div' : Fragment;

Expand Down Expand Up @@ -118,7 +117,7 @@
</>
) : (
<Text color='less-prominent' size='xs'>
<Localize i18n_default_text='Not rated yet' />
Not rated yet
</Text>
)}
</div>
Expand Down
Loading