Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ameerul / FEQ-2050 advertiser edge cases #58

Merged
merged 12 commits into from
May 10, 2024
Merged

Ameerul / FEQ-2050 advertiser edge cases #58

merged 12 commits into from
May 10, 2024

Conversation

ameerul-deriv
Copy link
Contributor

@ameerul-deriv ameerul-deriv commented May 9, 2024 •
edited
Loading

  • Added edge cases for share my ads feature
  • Refactored BuySellForm as it needs to call useAdvertInfo and not pass the advert directly to the Modal itself (since we need to subscribe to the advert info in the future for real time exchange rate)
  • Fixed Style issues
  • Fixed failing test cases
  • Updated deriv-com/ui library
Share.my.ads.desktop.mov
Share.my.ads.responsive.mov

Screenshot 2024-05-09 at 11 16 53 AM
Screenshot 2024-05-09 at 11 59 57 AM

Screenshot 2024-05-09 at 11 17 15 AM
Screenshot 2024-05-09 at 11 18 02 AM

Screenshot 2024-05-09 at 1 53 06 PM
Screenshot 2024-05-09 at 1 52 45 PM

@nada-deriv
Copy link
Contributor

can u check if the pr is updated with latest master? some changes are already there i guess

@nada-deriv nada-deriv closed this May 9, 2024
@ameerul-deriv ameerul-deriv reopened this May 9, 2024
@github-actions GitHub Actions
Copy link

Preview Link: https://FEQ-2050-advertiser1.deriv-p2p.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@farrah-deriv farrah-deriv merged commit ff34b3b into deriv-com:master May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nada-deriv nada-deriv nada-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

@markw-deriv markw-deriv Awaiting requested review from markw-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameerul-deriv @nada-deriv @farrah-deriv