Ameerul / Fix remaining test cases #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ameerul-deriv
commented
May 6, 2024
•
ameerul-deriv
commented
ameerul-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer,
markw-deriv and
farrah-deriv
as code owners
|
Preview Link: https://fix-test-cases-4.deriv-p2p.pages.dev
|
ameerul-deriv
commented
May 6, 2024
| }, | ||
| setupFilesAfterEnv: ['<rootDir>/jest.setup.ts'], | ||
| testEnvironment: 'jsdom', | ||
| testPathIgnorePatterns: ['useModalManager.spec.tsx'], |
There was a problem hiding this comment.
i have ignored the useModalManger test file as for some reason there is a lot of environment issues related to it, and in the future soon, this will be refactored once more...
There was a problem hiding this comment.
Agreed, this test case was causing issues with other test cases as well, I think for now this can be excluded
farrah-deriv
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.