Fix: Failing tests cases 2 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Link: https://fix-test-cases-2.deriv-p2p.pages.dev
|
ameerul-deriv
commented
May 2, 2024
| @@ -275,62 +275,6 @@ describe('PaymentMethodForm', () => { | |||
| ); | |||
| expect(onResetFormState).toHaveBeenCalled(); | |||
| }); | |||
| it('should show the error modal when a payment method is not created successfully and close it when the ok button is clicked', async () => { | |||
There was a problem hiding this comment.
there were some issues related to this modal, we need to migrate the modals to the one in deriv-com/ui and test the modals itself. But coverage is still at 100% for this component so it is safe to delete:
ameerul-deriv
commented
May 2, 2024
| @@ -64,25 +75,15 @@ describe('ProfileBalance', () => { | |||
| const dailyAvailableSellLimit = screen.getByTestId('dt_profile_balance_available_sell_limit'); | |||
| expect(within(dailyAvailableSellLimit).getByText('600.00 USD')).toBeInTheDocument(); | |||
| }); | |||
| it('should render eligibility for daily limit upgrade', async () => { | |||
| it('should render ProfileDailyLimit', () => { | |||
| mockAdvertiserStatsProp = { | |||
| advertiserStats: { | |||
| ...mockAdvertiserStatsProp.advertiserStats, | |||
| isEligibleForLimitUpgrade: true, | |||
| }, | |||
| }; | |||
| render(<ProfileBalance {...mockAdvertiserStatsProp} />); | |||
There was a problem hiding this comment.
Profile Daily Limit is already covered, both components have 100% coverage
There was a problem hiding this comment.
covered the daily limit modal test coverage above already
nada-deriv
approved these changes
May 2, 2024
farrah-deriv
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.