Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] P2PV2 style issues in buy sell section #37

Merged
merged 3 commits into from
Apr 30, 2024
Merged

[FEQ] P2PV2 style issues in buy sell section #37

merged 3 commits into from
Apr 30, 2024

Conversation

nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Apr 29, 2024

Buy sell form moved you'll recieve in sell form to below contact details,
active/inactive status tag style in myadstable fixed
buysell form to use modal manager

Before:
Screenshot 2024-04-29 at 4 49 31 PM
After:
Screenshot 2024-04-29 at 4 48 58 PM

@nada-deriv nada-deriv changed the title style issues in buy sell section [FEQ] P2PV2 style issues in buy sell section Apr 30, 2024
@@ -2,8 +2,9 @@ import { useEffect, useState } from 'react';
import { Controller, useForm } from 'react-hook-form';
import { TCurrency } from 'types';
import { LightDivider } from '@/components';
import { floatingPointValidator } from '@/utils';
import { Input, Text, useDevice } from '@deriv-com/ui';
import { VALID_SYMBOLS_PATTERN } from '@/constants';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check if we can have this from @deriv-com/utils

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked.. the one from deriv-com/utils seems to be different.

Copy link

Preview Link: https://nada-FEQ-2054-buy-se.deriv-p2p.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@farrah-deriv farrah-deriv merged commit 179f9b0 into deriv-com:master Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants