New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cypress Automation] - Add data-testid to HTML tags. #233

Merged

farrah-deriv merged 28 commits into deriv-com:master from usman-deriv:P2PS-2596

Aug 5, 2024

Contributor

usman-deriv commented Aug 1, 2024 •

edited

Loading

Changes:

Added data-testid attributes for various elements to ensure they are more resilient to changes in the UI for cypress automation.

Reason for Changes:

The previous locators were high maintenance in Cypress due to frequent changes in the UI structure. By adding the data-testid attributes, we aim to:

Reduce test failures caused by dynamic changes in the UI.
Enhance the maintainability of the test scripts.
Ensure that our test suite accurately reflects user interactions and behaviors.

ClickUp Card -> [For Cypress] Update locators for Automation
Google Sheet for Locators

usman-deriv added 2 commits

July 31, 2024 18:07


          test: added locators for cypress automation

b082c01


          Merge remote-tracking branch 'origin/master' into P2PS-2596

5a9f377

usman-deriv requested review from ali-hosseini-deriv, yashim-deriv, azmib-developer and farrah-deriv as code owners

August 1, 2024 04:52

usman-deriv added 8 commits

August 1, 2024 14:19


          test: removed changes done for class-name


          test: added remaining data-testids

b8bdfa5


          test: added data-testid for p2p guide learn more

d2fb2f6


          test: updated test files with new data test id


          test: updated test files with new data test id

9bbd59a


          test: updated test files with new data test id

f4782a9


          test: updated test files with new data test id

c6479dd


          test: coveralls update

08dadaf

coveralls commented Aug 1, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 10246380750

Details

6 of 6 (100.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 85.588%

Totals
Change from base Build 10244948373:	0.006%
Covered Lines:	5670
Relevant Lines:	6165

💛 - Coveralls

farrah-deriv reviewed

View reviewed changes

src/components/AdvertiserName/AdvertiserName.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/pages/orders/components/OrderDetailsCard/OrderDetailsCardInfo/OrderDetailsCardInfo.tsx Outdated Show resolved Hide resolved


          Update src/components/AdvertiserName/AdvertiserName.tsx

1d23ddb

Co-authored-by: Farrah Mae Ochoa <[email protected]>

matin-deriv reviewed

View reviewed changes

src/components/BuySellForm/BuySellData/BuySellData.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/AdvertiserName/AdvertiserNameToggle.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/AdvertiserName/AdvertiserNameToggle.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/BuySellForm/BuySellAmount/BuySellAmount.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/BuySellForm/BuySellAmount/BuySellAmount.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/BuySellForm/BuySellData/BuySellData.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/Modals/FilterModal/FilterModalContent/FilterModalContent.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/PopoverDropdown/PopoverDropdown.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/components/PopoverDropdown/PopoverDropdown.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/pages/buy-sell/components/CurrencyDropdown/CurrencyDropdown.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/pages/orders/components/ChatMessages/ChatMessages.tsx Outdated Show resolved Hide resolved

matin-deriv reviewed

View reviewed changes

src/pages/orders/components/ChatMessages/ChatMessages.tsx Outdated Show resolved Hide resolved

usman-deriv and others added 15 commits

August 2, 2024 15:53


          Update src/components/BuySellForm/BuySellAmount/BuySellAmount.tsx

f6ef46b

Co-authored-by: Matin shafiei <[email protected]>


          Update src/components/BuySellForm/BuySellData/BuySellData.tsx

75b1863

Co-authored-by: Matin shafiei <[email protected]>


          Update src/components/PopoverDropdown/PopoverDropdown.tsx

207efae

Co-authored-by: Matin shafiei <[email protected]>


          Update src/pages/orders/components/ChatMessages/ChatMessages.tsx

364039d

Co-authored-by: Matin shafiei <[email protected]>


          Update src/pages/buy-sell/components/CurrencyDropdown/CurrencyDropdow…

…n.tsx

Co-authored-by: Matin shafiei <[email protected]>


          Update src/pages/orders/components/ChatMessages/ChatMessages.tsx

66f3c99

Co-authored-by: Matin shafiei <[email protected]>


          Update src/components/PopoverDropdown/PopoverDropdown.tsx

1e4b4f7

Co-authored-by: Matin shafiei <[email protected]>


          Merge branch 'deriv-com:master' into P2PS-2596


          test: updated data-test id to use smake_case for advertiser name

a6ff12d


          test: updated data-test id to use smake_case for buysellamount.tsx

de3604e


          test: removed a spacer added by mistake

434025c


          test: added formatDataTestId method in format-value.ts and added it's…

06e9a7d

… import in the tsx used


          test: removed classname added by mistake

c35ce4d


          test: removed extra data-test id for toggle


          test: updated data-testids

c2a3e45

usman-deriv requested review from matin-deriv and farrah-deriv

August 2, 2024 11:04

farrah-deriv reviewed

View reviewed changes

src/components/AdvertiserName/AdvertiserNameToggle.tsx Outdated Show resolved Hide resolved


          test: removed div as discussed with Farrah for Toggle Switch

usman-deriv requested a review from farrah-deriv

August 5, 2024 01:30

farrah-deriv approved these changes

View reviewed changes

nada-deriv approved these changes

View reviewed changes

matin-deriv approved these changes

View reviewed changes


          Merge remote-tracking branch 'origin/master' into P2PS-2596

91bda41

github-actions bot commented Aug 5, 2024

Preview Link: https://P2PS-2596.p2p-standalone.pages.dev

Name	Result
Build status	Completed ✅
Preview URL	Visit Preview
Action URL	Visit Action

farrah-deriv merged commit 0103ab9 into deriv-com:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nada-deriv nada-deriv approved these changes

farrah-deriv farrah-deriv approved these changes

matin-deriv matin-deriv approved these changes

ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

azmib-developer Awaiting requested review from azmib-developer

Labels

None yet