Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yashim/fix: logout #230

Merged
merged 1 commit into from
Aug 1, 2024
Merged

yashim/fix: logout #230

merged 1 commit into from
Aug 1, 2024

Conversation

yashim-deriv
Copy link
Contributor

Description

  • @deriv-com/api-hooks logout() functionality now calls the logout api call
  • logout is now an async call
  • redirect to OAuth once done

@github-actions GitHub Actions
Copy link

Preview Link: https://fix-logout-button.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10174918089

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.623%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppHeader/MobileMenu/MobileMenuConfig.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 10174317142: 0.2%
Covered Lines: 5622
Relevant Lines: 6110
💛 - Coveralls

@yashim-deriv yashim-deriv merged commit 91d9e86 into deriv-com:master Aug 1, 2024
3 checks passed
@yashim-deriv yashim-deriv deleted the fix_logout_button branch August 1, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nada-deriv nada-deriv nada-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashim-deriv @coveralls @farrah-deriv @nada-deriv