Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle size issue import changed to import only currencies section #225

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: bundle size issue import changed to import only currencies section #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AppHeader/CurrencyIcon/CurrencyIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
const currencyName = currency.charAt(0).toUpperCase() + currency.slice(1).toLowerCase();
const currencyIconName = isVirtual ? 'CurrencyDemoIcon' : `Currency${currencyName}Icon`;
const getIconComponent = async () => {
const module = await import('@deriv/quill-icons');
const module = await import('@deriv/quill-icons/Currencies');
/* eslint-disable @typescript-eslint/no-explicit-any */
const IconComponent = (module as any)[currencyIconName];

Expand All @@ -20,7 +20,7 @@
};

getIconComponent();
}, []);

Check warning on line 23 in src/components/AppHeader/CurrencyIcon/CurrencyIcon.tsx

View workflow job for this annotation

GitHub Actions / build_to_cloudflare_pages 

React Hook useEffect has missing dependencies: 'currency' and 'isVirtual'. Either include them or remove the dependency array

return <Suspense fallback={<div />}>{currencyIconComponent}</Suspense>;
};
Expand Down
Loading