Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script for UTM initialisation #222

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Added script for UTM initialisation #222

merged 1 commit into from
Jul 29, 2024

Conversation

adrienne-deriv
Copy link
Contributor

@adrienne-deriv adrienne-deriv commented Jul 29, 2024

Integrated script to initalise UTM data for marketing analytics

Tested with http://localhost:5174/buy-sell?utm_source=adroll&utm_medium=ppc-display&utm_campaign=CCC&utm_campaign_id=DDD&utm_adgroup_id=EEE&signup_device=desktop:
Screenshot 2024-07-29 at 11 32 06 AM

Tested with http://localhost:5174/buy-sell?t=test&utm_source=AAA&utm_medium=BBB&utm_campaign=CCC:
Screenshot 2024-07-29 at 11 30 21 AM
Screenshot 2024-07-29 at 11 30 14 AM

Copy link

Preview Link: https://init-utm-script.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10137636049

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.442%

Totals Coverage Status
Change from base Build 10108699185: 0.0%
Covered Lines: 5605
Relevant Lines: 6102

💛 - Coveralls

Copy link
Contributor

@amam-deriv amam-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was thinking if we can follow deriv app to put the script below GTM script init. however since its async script, it will defer the init and should be ok. Overall LGTM!

Great testing!

@farrah-deriv farrah-deriv merged commit f7e5ed2 into deriv-com:master Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants