Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shayan/feq-2372/fix iframe path issue #121

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Shayan/feq-2372/fix iframe path issue #121

merged 4 commits into from
Jun 12, 2024

Conversation

shayan-deriv
Copy link
Contributor

issue:

deriv-app iframe is not loaded inside p2p

changes:

  • updated the way we are linking iframe to its html file
  • added a public folder so the file can be accessible publicly
  • updated utils library's version to get p2p url

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9476341193

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 74.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DerivIframe/DerivIframe.tsx 2 4 50.0%
Totals Coverage Status
Change from base Build 9463251896: -0.006%
Covered Lines: 4487
Relevant Lines: 5421

💛 - Coveralls

Copy link

Preview Link: https://shayan-fix-iframe-pa.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9476385553

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 74.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DerivIframe/DerivIframe.tsx 2 4 50.0%
Totals Coverage Status
Change from base Build 9463251896: -0.006%
Covered Lines: 4487
Relevant Lines: 5421

💛 - Coveralls

@ali-hosseini-deriv ali-hosseini-deriv merged commit ae86cd0 into deriv-com:master Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants