Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nada/feq 1712/date filter #119

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Nada/feq 1712/date filter #119

merged 8 commits into from
Jun 12, 2024

Conversation

nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Jun 11, 2024 •
edited
Loading

Screen.Recording.2024-06-11.at.2.53.51.PM.mov
Screenshot 2024-06-11 at 3 35 30 PM Screenshot 2024-06-11 at 3 39 33 PM Screenshot 2024-06-11 at 3 46 18 PM Screenshot 2024-06-11 at 4 04 07 PM

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9464460643

Details

  • 53 of 100 (53.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 73.968%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DateTextField/DateTextField.tsx 6 7 85.71%
src/components/DatePicker/utils.ts 3 7 42.86%
src/pages/orders/components/OrdersDateSelectionFullPage/OrdersDateSelectionFullPage.tsx 7 16 43.75%
src/pages/orders/components/OrdersDateSelection/OrdersDateSelection.tsx 9 21 42.86%
src/components/DatePicker/DatePicker.tsx 10 31 32.26%
Totals Coverage Status
Change from base Build 9463251896: -0.8%
Covered Lines: 4536
Relevant Lines: 5516
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9464922958

Details

  • 53 of 100 (53.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 73.968%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DateTextField/DateTextField.tsx 6 7 85.71%
src/components/DatePicker/utils.ts 3 7 42.86%
src/pages/orders/components/OrdersDateSelectionFullPage/OrdersDateSelectionFullPage.tsx 7 16 43.75%
src/pages/orders/components/OrdersDateSelection/OrdersDateSelection.tsx 9 21 42.86%
src/components/DatePicker/DatePicker.tsx 10 31 32.26%
Totals Coverage Status
Change from base Build 9463251896: -0.8%
Covered Lines: 4536
Relevant Lines: 5516
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9465155483

Details

  • 97 of 100 (97.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.149%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DatePicker/DatePicker.tsx 27 30 90.0%
Totals Coverage Status
Change from base Build 9463251896: 0.4%
Covered Lines: 4579
Relevant Lines: 5511
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9465167941

Details

  • 97 of 100 (97.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.149%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DatePicker/DatePicker.tsx 27 30 90.0%
Totals Coverage Status
Change from base Build 9463251896: 0.4%
Covered Lines: 4579
Relevant Lines: 5511
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9465265118

Details

  • 98 of 101 (97.03%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.149%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DatePicker/DatePicker.tsx 28 31 90.32%
Totals Coverage Status
Change from base Build 9463251896: 0.4%
Covered Lines: 4579
Relevant Lines: 5511
💛 - Coveralls

ameerul-deriv
ameerul-deriv approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Preview Link: https://nada-FEQ-1712-date-f.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9478715836

Details

  • 93 of 97 (95.88%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.079%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DerivIframe/DerivIframe.tsx 0 1 0.0%
src/components/DatePicker/DatePicker.tsx 27 30 90.0%
Totals Coverage Status
Change from base Build 9477306641: 0.4%
Covered Lines: 4575
Relevant Lines: 5512
💛 - Coveralls

@farrah-deriv farrah-deriv merged commit e8eb9db into deriv-com:master Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

@shayan-deriv shayan-deriv shayan-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nada-deriv @coveralls @shayan-deriv @ameerul-deriv @farrah-deriv