Shayan/feq 2336/redirect guest users to login page #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayan-deriv
commented
Jun 10, 2024
Comment on lines
-84
to
94
| as: 'button', | ||
| href: 'https://app.deriv.com/appstore/traders-hub', | ||
| as: 'a', | ||
| href: 'https://app.deriv.com/appstore/reports', | ||
| icon: <ReportsLogo iconSize='xs' />, | ||
| label: 'Reports', | ||
| }, | ||
| { | ||
| as: 'button', | ||
| href: 'https://app.deriv.com/appstore/traders-hub', | ||
| as: 'a', | ||
| href: 'https://app.deriv.com/appstore/cashier', | ||
| icon: <CashierLogo iconSize='xs' />, | ||
| label: 'Cashier', | ||
| }, |
There was a problem hiding this comment.
this is not in this PR's scope but I just fixed it here
…6/redirect-guest-users-to-login-page
shayan-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
|
Preview Link: https://shayan-feq-2336-redi.p2p-standalone.pages.dev
|
shayan-deriv
commented
Jun 11, 2024
| @@ -12,7 +12,7 @@ const useIsAdvertiser = (): boolean => { | |||
| const [isAdvertiser, setIsAdvertiser] = useState(!error && !isEmptyObject(data)); | |||
|
|
|||
| useEffect(() => { | |||
| if (error && error?.error.code === ERROR_CODES.ADVERTISER_NOT_FOUND) { | |||
| if (error && error?.code === ERROR_CODES.ADVERTISER_NOT_FOUND) { | |||
There was a problem hiding this comment.
this is due to error message structure change in api-hooks library
shayan-deriv
commented
Jun 11, 2024
| @@ -80,7 +80,7 @@ const OrderDetails = () => { | |||
| if (isLoading || (!orderInfo && !error)) return <Loader isFullScreen />; | |||
|
|
|||
| // TODO: replace with proper error screen once design is ready | |||
| if (error) return <Text>{error?.error?.message}</Text>; | |||
| if (error) return <Text>{error?.message}</Text>; | |||
There was a problem hiding this comment.
this is due to error message structure change in api-hooks library
shayan-deriv
commented
Jun 11, 2024
| @@ -225,7 +225,7 @@ describe('<OrderDetails />', () => { | |||
| (mockUseGet as jest.Mock).mockReturnValue({ | |||
| ...mockUseGet(), | |||
| data: {}, | |||
| error: { error: { message: 'error message' } }, | |||
| error: { code: 'code', message: 'error message' }, | |||
There was a problem hiding this comment.
this is due to error message structure change in api-hooks library
shayan-deriv
commented
Jun 11, 2024
|
|
||
| type TContextValue = { | ||
| error: TSocketError<'p2p_advertiser_info'> | undefined; | ||
| error: { code: string; message: string } | undefined; |
There was a problem hiding this comment.
this is due to error message structure change in api-hooks library
Pull Request Test Coverage Report for Build 9461576364Details
💛 - Coveralls |
ali-hosseini-deriv
approved these changes
Jun 11, 2024
matin-deriv
approved these changes
Jun 11, 2024
farrah-deriv
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.